From: Breno Leitao <leitao@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: sreenivasa.honnur@neterion.com, joe@perches.com, netdev@vger.kernel.org
Subject: Re: [PATCH] s2io: fixing DBG_PRINT() macro
Date: Fri, 05 Mar 2010 11:21:06 -0300 [thread overview]
Message-ID: <4B911352.2000407@linux.vnet.ibm.com> (raw)
In-Reply-To: <1267623697-14781-1-git-send-email-leitao@linux.vnet.ibm.com>
David,
Due my mistake I didn't send this patch to Sreenivasa. After
sending this patch to netdev, I forward to him, and
he acked it privately.
Sorry for the confusion.
Thanks,
Breno
leitao@linux.vnet.ibm.com wrote:
> Patch 9e39f7c5b311a306977c5471f9e2ce4c456aa038 changed the
> DBG_PRINT() macro and the if clause was changed. It means
> that currently all the DBG_PRINT are being printed, flooding
> the kernel log buffer with thinkgs like:
>
> s2io: eth6: Next block at: c0000000b9c90000
> s2io: eth6: In Neterion Tx routine
>
> This patch just fixes the if clause condition.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
> ---
> drivers/net/s2io.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h
> index 47c36e0..3b6f45d 100644
> --- a/drivers/net/s2io.h
> +++ b/drivers/net/s2io.h
> @@ -65,7 +65,7 @@ static int debug_level = ERR_DBG;
>
> /* DEBUG message print. */
> #define DBG_PRINT(dbg_level, fmt, args...) do { \
> - if (dbg_level >= debug_level) \
> + if (dbg_level <= debug_level) \
> pr_info(fmt, ##args); \
> } while (0)
>
parent reply other threads:[~2010-03-05 14:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1267623697-14781-1-git-send-email-leitao@linux.vnet.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B911352.2000407@linux.vnet.ibm.com \
--to=leitao@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=sreenivasa.honnur@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).