From: Daniel Borkmann <danborkmann@googlemail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Daniel Borkmann <danborkmann@googlemail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: bug report: netpoll: allow execution of multiple rx_hooks per interface
Date: Wed, 10 Mar 2010 12:13:31 +0100 [thread overview]
Message-ID: <4B977EDB.5010202@gmail.com> (raw)
In-Reply-To: <20100306110659.GE4958@bicker>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
Hi Dan,
Dan Carpenter wrote:
> Smatch complains about 508e14b4a4f: netpoll: allow execution of multiple
> rx_hooks per interface
>
> net/core/netpoll.c +840 netpoll_setup(124) error: potential null dereference 'npinfo'. (kmalloc returns null)
> 839 if (!ndev->npinfo) {
> 840 spin_lock_irqsave(&npinfo->rx_lock, flags);
>
> npinfo can be null here if the kmalloc() failed.
>
> 841 list_for_each_entry_safe(npe, tmp, &npinfo->rx_np, rx) {
> 842 npe->dev = NULL;
> 843 }
> 844 spin_unlock_irqrestore(&npinfo->rx_lock, flags);
> 845
> 846 kfree(npinfo);
> 847 }
Sorry for the late reply, I'm currently on holiday and have hardly
access to the Internet. I'll fix the problem as soon as possible.
You'll hear from me.
Thanks,
Daniel
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
next parent reply other threads:[~2010-03-10 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100306110659.GE4958@bicker>
2010-03-10 11:13 ` Daniel Borkmann [this message]
2010-03-10 14:52 ` bug report: netpoll: allow execution of multiple rx_hooks per interface David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B977EDB.5010202@gmail.com \
--to=danborkmann@googlemail.com \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).