* Re: bug report: netpoll: allow execution of multiple rx_hooks per interface
[not found] <20100306110659.GE4958@bicker>
@ 2010-03-10 11:13 ` Daniel Borkmann
2010-03-10 14:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Borkmann @ 2010-03-10 11:13 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Daniel Borkmann, netdev, David S. Miller
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
Hi Dan,
Dan Carpenter wrote:
> Smatch complains about 508e14b4a4f: netpoll: allow execution of multiple
> rx_hooks per interface
>
> net/core/netpoll.c +840 netpoll_setup(124) error: potential null dereference 'npinfo'. (kmalloc returns null)
> 839 if (!ndev->npinfo) {
> 840 spin_lock_irqsave(&npinfo->rx_lock, flags);
>
> npinfo can be null here if the kmalloc() failed.
>
> 841 list_for_each_entry_safe(npe, tmp, &npinfo->rx_np, rx) {
> 842 npe->dev = NULL;
> 843 }
> 844 spin_unlock_irqrestore(&npinfo->rx_lock, flags);
> 845
> 846 kfree(npinfo);
> 847 }
Sorry for the late reply, I'm currently on holiday and have hardly
access to the Internet. I'll fix the problem as soon as possible.
You'll hear from me.
Thanks,
Daniel
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread