From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [Patch] netpoll: allow spaces in its parameter
Date: Wed, 17 Mar 2010 14:01:06 +0800 [thread overview]
Message-ID: <4BA07022.1040702@redhat.com> (raw)
In-Reply-To: <20100316.225431.200776775.davem@davemloft.net>
David Miller wrote:
> From: Amerigo Wang <amwang@redhat.com>
> Date: Wed, 17 Mar 2010 01:53:26 -0400
>
>> It would be nice if we allow spaces in netconsole parameters,
>> otherwise we get weird results if there are spaces in it.
>>
>> After this patch, we will allow things like:
>> "netconsole= @192.168.0.1/eth0 , 66666@192.168.0.2/".
>>
>> Signed-off-by: WANG Cong <amwang@redhat.com>
>> Cc: David Miller <davem@davemloft.net>
>
> That kernel command line looks absolutely awful, not
> better.
>
> Sorry I'm not applying this.
The problem is that the dst port is 0 when I even use:
"netconsole=@192.168.0.1/eth0, 66666@192.168.0.2/"
This is awful too? I don't think so...
next prev parent reply other threads:[~2010-03-17 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 5:53 [Patch] netpoll: allow spaces in its parameter Amerigo Wang
2010-03-17 5:54 ` David Miller
2010-03-17 6:01 ` Cong Wang [this message]
2010-03-17 5:59 ` David Miller
2010-03-17 6:07 ` Cong Wang
2010-03-17 6:14 ` David Miller
2010-03-17 6:38 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA07022.1040702@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).