From: Cong Wang <amwang@redhat.com>
To: Frans Pop <elendil@planet.nl>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net
Subject: Re: [Patch] netpoll: warn when there are spaces in parameters
Date: Thu, 18 Mar 2010 10:02:37 +0800 [thread overview]
Message-ID: <4BA189BD.7070400@redhat.com> (raw)
In-Reply-To: <201003171158.49549.elendil@planet.nl>
Frans Pop wrote:
> Amerigo Wang wrote:
>> + if (*cur == ' ' || *cur == '\t')
>> + printk(KERN_INFO "%s: warning: white spaces"
>> + "are not allowed.\n", np->name);
>>
>
> The term "white spaces" not correct. Please change the message to
> "whitespace is not allowed".
>
> Also, it's normally not necessary to close kernel messages with a period;
> most kernel messages do not have a closing period. Messages are not
> sentences and the periods only help increase the kernel size.
>
Ok, I will update it.
Thanks.
prev parent reply other threads:[~2010-03-18 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 10:12 [Patch] netpoll: warn when there are spaces in parameters Amerigo Wang
2010-03-17 10:58 ` Frans Pop
2010-03-18 2:02 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA189BD.7070400@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).