[Patch] netpoll: warn when there are spaces in parameters

[Patch] netpoll: warn when there are spaces in parameters

[Amerigo Wang]

Currently, if we leave spaces before dst port,
netconsole will silently accept it as 0. Warn about this.

Also, when spaces appear in other places, make them
visible in error messages.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: David Miller <davem@davemloft.net>

---

diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 7aa6972..6df1863 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -614,7 +614,7 @@ void netpoll_print_options(struct netpoll *np)
 			 np->name, np->local_port);
 	printk(KERN_INFO "%s: local IP %pI4\n",
 			 np->name, &np->local_ip);
-	printk(KERN_INFO "%s: interface %s\n",
+	printk(KERN_INFO "%s: interface '%s'\n",
 			 np->name, np->dev_name);
 	printk(KERN_INFO "%s: remote port %d\n",
 			 np->name, np->remote_port);
@@ -661,6 +661,9 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
 		if ((delim = strchr(cur, '@')) == NULL)
 			goto parse_failed;
 		*delim = 0;
+		if (*cur == ' ' || *cur == '\t')
+			printk(KERN_INFO "%s: warning: white spaces"
+					"are not allowed.\n", np->name);
 		np->remote_port = simple_strtol(cur, NULL, 10);
 		cur = delim;
 	}
@@ -708,7 +711,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
 	return 0;
 
  parse_failed:
-	printk(KERN_INFO "%s: couldn't parse config at %s!\n",
+	printk(KERN_INFO "%s: couldn't parse config at '%s'!\n",
 	       np->name, cur);
 	return -1;
 }

Re: [Patch] netpoll: warn when there are spaces in parameters

[Frans Pop]

Amerigo Wang wrote:
> +               if (*cur == ' ' || *cur == '\t')
> +                       printk(KERN_INFO "%s: warning: white spaces"
> +                                       "are not allowed.\n", np->name);
> 

The term "white spaces" not correct. Please change the message to
"whitespace is not allowed".

Also, it's normally not necessary to close kernel messages with a period; 
most kernel messages do not have a closing period. Messages are not 
sentences and the periods only help increase the kernel size.

Thanks,
FJP

Re: [Patch] netpoll: warn when there are spaces in parameters

[Cong Wang]

Frans Pop wrote:
> Amerigo Wang wrote:
>> +               if (*cur == ' ' || *cur == '\t')
>> +                       printk(KERN_INFO "%s: warning: white spaces"
>> +                                       "are not allowed.\n", np->name);
>>
> 
> The term "white spaces" not correct. Please change the message to
> "whitespace is not allowed".
> 
> Also, it's normally not necessary to close kernel messages with a period; 
> most kernel messages do not have a closing period. Messages are not 
> sentences and the periods only help increase the kernel size.
> 

Ok, I will update it.

Thanks.