From: Cong Wang <amwang@redhat.com>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
elendil@planet.nl, David Miller <davem@davemloft.net>
Subject: Re: [Patch v2] netpoll: warn when there are spaces in parameters
Date: Tue, 23 Mar 2010 09:44:56 +0800 [thread overview]
Message-ID: <4BA81D18.40509@redhat.com> (raw)
In-Reply-To: <1269296535.3552.10.camel@calx>
Matt Mackall wrote:
> On Mon, 2010-03-22 at 04:59 -0400, Amerigo Wang wrote:
>> + printk(KERN_INFO "%s: warning: whitespace"
>> + "is not allowed\n", np->name);
>
> Is it a warning or is it info? If it's a warning, then we probably need
> to add "netpoll" or whatever to the message so that people who've got a
> warning-level threshold will know what it's about.
>
If you mean KERN_INFO, yeah, I want to keep it in the same level
as other messages around.
Also, I already put "np->name" which will be "netconsole" when
we use netconsole.
Thanks.
next prev parent reply other threads:[~2010-03-23 1:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 8:59 [Patch v2] netpoll: warn when there are spaces in parameters Amerigo Wang
2010-03-22 12:30 ` Neil Horman
2010-03-23 3:06 ` David Miller
2010-03-22 22:22 ` Matt Mackall
2010-03-23 1:44 ` Cong Wang [this message]
2010-03-23 4:24 ` Matt Mackall
2010-03-23 4:34 ` Cong Wang
2010-03-23 4:45 ` Matt Mackall
2010-03-23 4:56 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA81D18.40509@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).