From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: mpm@selenic.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
gospo@redhat.com, nhorman@tuxdriver.com,
shemminger@linux-foundation.org,
bonding-devel@lists.sourceforge.net, fubar@us.ibm.com
Subject: Re: [RFC Patch 2/3] bridge: make bridge support netpoll
Date: Tue, 23 Mar 2010 13:06:12 +0800 [thread overview]
Message-ID: <4BA84C44.4030707@redhat.com> (raw)
In-Reply-To: <20100322.215703.77339158.davem@davemloft.net>
David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Tue, 23 Mar 2010 12:39:35 +0800
>
>> How could you let the bridge know netpoll is not sent to
>> the one that doesn't support netpoll during setup? This will
>> be complex, I am afraid.
>
> Why does this matter at all?
Because currently we check netpoll support by ->ndo_poll_controller,
for example, tap driver doesn't have ->ndo_poll_controller now,
if I choose the target "@192.168.0.2/br0" where "192.168.0.2" is owned
by "tap0" which is managed by "br0", netconsole may not work.
>
> I told you in another mail that we should do away with
> these callbacks and all the crazy 'npinfo' assignments
> and just do it in the generic code.
I think ->ndo_poll_controller is not in the case that you talked about.
Thanks.
next prev parent reply other threads:[~2010-03-23 5:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 8:17 [RFC Patch 1/3] netpoll: add generic support for bridge and bonding devices Amerigo Wang
2010-03-22 8:17 ` [RFC Patch 2/3] bridge: make bridge support netpoll Amerigo Wang
2010-03-22 22:35 ` Matt Mackall
2010-03-23 2:03 ` Cong Wang
2010-03-23 4:27 ` Matt Mackall
2010-03-23 4:39 ` Cong Wang
2010-03-23 4:51 ` Matt Mackall
2010-03-23 4:59 ` David Miller
2010-03-23 5:00 ` Cong Wang
2010-03-23 4:57 ` David Miller
2010-03-23 5:06 ` Cong Wang [this message]
2010-03-22 8:17 ` [RFC Patch 3/3] bonding: make bonding " Amerigo Wang
2010-03-22 22:38 ` Matt Mackall
2010-03-22 23:36 ` Jay Vosburgh
2010-03-23 2:01 ` Cong Wang
2010-03-23 0:56 ` Andy Gospodarek
2010-03-23 1:49 ` Cong Wang
2010-03-22 22:31 ` [RFC Patch 1/3] netpoll: add generic support for bridge and bonding devices Matt Mackall
2010-03-23 2:13 ` Cong Wang
2010-03-23 3:49 ` David Miller
2010-03-23 4:47 ` Cong Wang
2010-03-23 4:58 ` David Miller
2010-03-23 5:15 ` Cong Wang
2010-03-23 12:11 ` Jeff Moyer
2010-03-24 2:29 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA84C44.4030707@redhat.com \
--to=amwang@redhat.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=gospo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).