netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@openvz.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: David Miller <davem@davemloft.net>,
	Eric Dumazet <dada1@cosmosbay.com>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] ipv4: Restart rt_intern_hash after emergency rebuild
Date: Thu, 25 Mar 2010 10:44:13 +0300	[thread overview]
Message-ID: <4BAB144D.3070403@openvz.org> (raw)
In-Reply-To: <20100324195725.GC29364@hmsreliant.think-freely.org>

>> @@ -1217,6 +1217,12 @@ restart:
>>  					rt->u.dst.dev->name, num);
>>  			}
>>  			rt_emergency_hash_rebuild(net);
>> +			spin_unlock_bh(rt_hash_lock_addr(hash));
>> +
>> +			hash = rt_hash(rt->fl.fl4_dst, rt->fl.fl4_src,
>> +					in ? rt->fl.iif : rt->fl.oif,
>> +					rt_genid(net));
>> +			goto restart;
>>  		}
>>  	}
> Why pass in a flag here?  Perhaps it would be easier just to pass in the ifindex
> that was origionally used by the caller of rt_intern_hash so that the hash could
> be redone without needing to toggle on the value of the flag.  

That's perfectly fine with me. I'll resend the patch shortly.

> Regards
> Neil
> 
>>
> 


  reply	other threads:[~2010-03-25  7:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 17:43 [PATCH 2/2] ipv4: Restart rt_intern_hash after emergency rebuild Pavel Emelyanov
2010-03-24 20:21 ` Neil Horman
2010-03-25  7:44   ` Pavel Emelyanov [this message]
2010-03-25  7:51 ` [PATCH 2/2] ipv4: Restart rt_intern_hash after emergency rebuild (v2) Pavel Emelyanov
2010-03-25 13:17   ` Neil Horman
2010-03-27  3:58     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BAB144D.3070403@openvz.org \
    --to=xemul@openvz.org \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).