Re: [PATCH] e1000e: export some settings using ethtool private flags

[Jeff Garzik <jeff@garzik.org>]

On 03/25/2010 01:16 PM, Tantilov, Emil S wrote:
> Jeff Garzik wrote:
>> The ethtool private flags interface exists to get/set driver-specific
>> settings at runtime, in a flexible manner.
>>
>> Use this facility to export a couple e1000e features, that were
>> previously only set at module initialization time.
>>
>> Signed-off-by: Jeff Garzik<jgarzik@redhat.com>
>> ---
>>   drivers/net/e1000e/ethtool.c |   27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>
> Jeff,
>
> What is the use case for the ethtool private flags?

It is stated in the changelog above :)  It enables feature setting at 
setting, on an easy, per-network-interface basis, that were previously 
only settable at module initialization (ie. load) time.


> At least I don't see an option in ethtool that would make use of them.

This is added in a separate patch, since the above patch is the first to 
make use of the private-flags ethtool mechanism.

	Jeff