From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alexander E. Patrakov" Subject: Re: [Patch] fix packet loss and massive ping spikes with PPP multi-link Date: Fri, 26 Mar 2010 22:00:23 +0500 Message-ID: <4BACE827.4070006@gmail.com> References: <2d460de71003260850x7f90d04cy79ac853464108182@mail.gmail.com> <20100326160226.0159ac3b@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Richard Hartmann , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-ppp@vger.kernel.org To: Alan Cox Return-path: Received: from mail-fx0-f223.google.com ([209.85.220.223]:65522 "EHLO mail-fx0-f223.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795Ab0CZQ6u (ORCPT ); Fri, 26 Mar 2010 12:58:50 -0400 In-Reply-To: <20100326160226.0159ac3b@lxorguk.ukuu.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: 26.03.2010 21:02, Alan Cox wrote: > You can then do this > > static int ml_explode = 1; > module_param(ml_explode, int, 0600); > MODULE_PARM_DESC(ml_expode, "Set this to zero to disabling multilink \ > fragmentation when talking to cisco devices"); > > which will let you load the module with the option ml_explode = 0 if you > want that property. > > Making it runtime per link selectable would be nicer but thats a bit more > work. Doesn't it work already via echoing values to /sys/module/ppp/generic/parameters/ml_explode in the above code? -- Alexander E. Patrakov