From: "Timo Teräs" <timo.teras@iki.fi>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] xfrm: remove policy lock when accessing policy->walk.dead
Date: Tue, 30 Mar 2010 18:36:37 +0300 [thread overview]
Message-ID: <4BB21A85.2030203@iki.fi> (raw)
In-Reply-To: <20100330142914.GA6840@gondor.apana.org.au>
Herbert Xu wrote:
> On Tue, Mar 30, 2010 at 05:01:47PM +0300, Timo Teräs wrote:
>> Since the exported function xfrm_policy_byid() can result in deletion
>> of socket policy, it's safer to leave this change in. This is can be
>> even triggered via xfrm_user since it does not check 'dir' for the
>> policy expired message it handles. Any custom module could do similar
>> harm.
>
> That's a bug. Socket policies should never be deleted by anyone
> other than the socket owner through a setsockopt.
Ok. I can remove the change to xfrm_sk_policy_insert() if you want.
I only added it because it's non-trivial to figure out if there's
any code path that could race. It's a great help for reader of the
code to see that it's correct even if it's not strictly needed.
My initial feeling is that the change produces better code as the
original 'old_pol' does not have to get stored and restored.
I'm fine either way.
I will also include a patch to fix the missing 'dir' check in
xfrm_user.
next prev parent reply other threads:[~2010-03-30 15:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 14:12 [PATCH 0/7] caching bundles, iteration 2 Timo Teras
2010-03-29 14:12 ` [PATCH 1/7] xfrm: remove policy lock when accessing policy->walk.dead Timo Teras
2010-03-29 14:43 ` Herbert Xu
2010-03-30 4:55 ` Timo Teräs
2010-03-30 11:53 ` Herbert Xu
2010-03-30 12:04 ` Timo Teräs
2010-03-30 12:14 ` Herbert Xu
2010-03-30 12:21 ` Timo Teräs
2010-03-30 12:23 ` Herbert Xu
2010-03-30 12:41 ` Timo Teräs
2010-03-30 12:48 ` Herbert Xu
2010-03-30 13:33 ` Timo Teräs
2010-03-30 14:30 ` Herbert Xu
2010-03-30 14:34 ` Herbert Xu
2010-03-30 14:37 ` Herbert Xu
2010-03-30 14:01 ` Timo Teräs
2010-03-30 14:29 ` Herbert Xu
2010-03-30 15:36 ` Timo Teräs [this message]
2010-03-31 0:43 ` Herbert Xu
2010-03-29 14:12 ` [PATCH 2/7] flow: structurize flow cache Timo Teras
2010-03-30 12:01 ` Herbert Xu
2010-03-30 12:02 ` Timo Teräs
2010-03-30 12:15 ` Herbert Xu
2010-03-29 14:12 ` [PATCH 3/7] flow: allocate hash table for online cpus only Timo Teras
2010-03-30 12:12 ` Herbert Xu
2010-03-31 12:32 ` Rusty Russell
2010-03-31 13:27 ` Timo Teräs
2010-03-29 14:12 ` [PATCH 4/7] flow: delayed deletion of flow cache entries Timo Teras
2010-03-30 12:22 ` Herbert Xu
2010-03-30 12:32 ` Timo Teräs
2010-03-30 12:36 ` Herbert Xu
2010-03-30 12:43 ` Timo Teräs
2010-03-29 14:12 ` [PATCH 5/7] flow: virtualize get and entry deletion methods Timo Teras
2010-03-29 14:12 ` [PATCH 6/7] xfrm: cache bundles instead of policies for outgoing flows Timo Teras
2010-03-29 14:12 ` [PATCH 7/7] xfrm: remove policy garbage collection Timo Teras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB21A85.2030203@iki.fi \
--to=timo.teras@iki.fi \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).