From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Anders Darander <anders.darander@datarespons.se>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>,
Erik Waling <erik.waling@konftel.com>,
Patrick McHardy <kaber@trash.net>,
Grant Likely <grant.likely@secretlab.ca>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] MACB: Set PHY address in kernel parameters
Date: Wed, 31 Mar 2010 11:48:26 +0200 [thread overview]
Message-ID: <4BB31A6A.1000503@pengutronix.de> (raw)
In-Reply-To: <20100331093956.GI4837@datarespons.se>
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
Anders Darander wrote:
> * Marc Kleine-Budde <mkl@pengutronix.de> [100331 11:18]:
>> We're using phy_mask in one of our projects, it's still using 2.6.29,
>> though. I think it's worth testing if it's still working.
>
> Well, that was obviously something I overlooked / misinterpreted when I
> tried to solve our problem!
>
> As I understand it, phy_mask is a bitfield for setting which PHYs should
> be enabled... Then this should have worked OK for us!
Yes, it's a bitmask of PHYs that should be probed.
>> static struct at91_eth_data __initdata p298_macb_data = {
>> .is_rmii = 0,
>> .phy_mask = ~(1 << 8),
>> };
>
>> at91_add_device_eth(&p298_macb_data);
>
> I've not tested it, but it should probably have worked.
Cheers, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
prev parent reply other threads:[~2010-03-31 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 8:46 [PATCH][V2] MACB: Set PHY address in kernel parameters Anders Darander
2010-03-31 9:17 ` Marc Kleine-Budde
2010-03-31 9:39 ` Anders Darander
2010-03-31 9:48 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB31A6A.1000503@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=anders.darander@datarespons.se \
--cc=davem@davemloft.net \
--cc=erik.waling@konftel.com \
--cc=grant.likely@secretlab.ca \
--cc=hskinnemoen@atmel.com \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).