From: Bryan Wu <bryan.wu@canonical.com>
To: Wolfram Sang <w.sang@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@lists.ubuntu.com, gerg@uclinux.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] netdev/fec.c: add phylib supporting to enable carrier detection
Date: Wed, 31 Mar 2010 20:11:50 +0800 [thread overview]
Message-ID: <4BB33C06.1040307@canonical.com> (raw)
In-Reply-To: <20100331081004.GB23391@pengutronix.de>
On 03/31/2010 04:10 PM, Wolfram Sang wrote:
>> With rounding this would be:
>>
>> (clk_get_rate() + 4999999) / 5000000
>
> Better use DIV_ROUND_UP(clk_get_rate(), 5000000)?
>
> Regards,
>
> Wolfram
>
Sascha and Wolfram,
Thanks a lot. I updated the patch to v2 and sent it already.
--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.138-1617-6545 Mobile
Ubuntu Kernel Team | Hardware Enablement Team
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
next prev parent reply other threads:[~2010-03-31 12:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 9:50 [PATCH] netdev/fec.c: add phylib supporting to enable carrier detection Bryan Wu
2010-03-26 10:29 ` Amit Kucheria
2010-03-31 8:12 ` Sascha Hauer
2010-03-26 14:47 ` Wolfram Sang
2010-03-27 12:57 ` Wolfram Sang
2010-03-29 8:40 ` Bryan Wu
2010-03-31 3:06 ` Wolfram Sang
2010-03-31 3:07 ` Bryan Wu
2010-03-31 2:49 ` Bryan Wu
2010-03-31 7:57 ` Sascha Hauer
2010-03-31 8:10 ` Wolfram Sang
2010-03-31 8:15 ` Sascha Hauer
2010-03-31 12:11 ` Bryan Wu [this message]
2010-04-21 5:42 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB33C06.1040307@canonical.com \
--to=bryan.wu@canonical.com \
--cc=gerg@uclinux.org \
--cc=kernel-team@lists.ubuntu.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).