From: Steve Wise <swise@opengridcomputing.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@vyatta.com, dm@chelsio.com, netdev@vger.kernel.org
Subject: Re: [PATCH 5/6] cxgb4: Add main driver file and driver Makefile
Date: Wed, 31 Mar 2010 14:31:13 -0500 [thread overview]
Message-ID: <4BB3A301.3090100@opengridcomputing.com> (raw)
In-Reply-To: <20100330.225042.107712654.davem@davemloft.net>
David Miller wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Tue, 30 Mar 2010 14:19:04 -0700
>
>
>> On Tue, 30 Mar 2010 10:52:21 -0800
>> Dimitris Michailidis <dm@chelsio.com> wrote:
>>
>>
>>> +static struct cxgb4_proc_entry proc_files[] = {
>>> +#ifdef CONFIG_PROC_FS
>>> + { "l2t", 0444, ADAP_NEED_L2T, 0, &t4_l2t_proc_fops },
>>> +#endif
>>> + { "lb_stats", 0444, 0, 0, &lb_stats_proc_fops },
>>> + { "path_mtus", 0644, 0, 0, &mtutab_proc_fops },
>>> + { "qstats", 0444, 0, 0, &sge_stats_proc_fops },
>>> + { "rss", 0444, 0, 0, &rss_proc_fops },
>>> + { "tcp_stats", 0444, 0, 0, &tcp_stats_proc_fops },
>>> + { "tids", 0444, ADAP_NEED_OFLD, 0, &tid_info_proc_fops },
>>> + { "tp_err_stats", 0444, 0, 0, &tp_err_stats_proc_fops },
>>> + { "trace0", 0644, 0, 0, &mps_trc_proc_fops },
>>> + { "trace1", 0644, 0, 1, &mps_trc_proc_fops },
>>> + { "trace2", 0644, 0, 2, &mps_trc_proc_fops },
>>> + { "trace3", 0644, 0, 3, &mps_trc_proc_fops },
>>> + { "uld", 0444, 0, 0, &uld_proc_fops },
>>> +};
>>> +
>>>
>> Do you really need this large number of /proc files.
>> It creates another stable API to worry about. If it is just for
>> debugging move it to debugfs, or better yet just drop it.
>>
>
> I also find this a bit too much.
>
> We have all kinds of ways to export whatever statistics you
> want. In particular we have ethtool stats of which you
> can have as many as you wish.
>
> If necessary, we could add a feature to define "views" of ethtool
> stats so that we can have domains of driver specific statistics if the
> problem is that you don't want all of these debugging stats to clutter
> up the "main" ethtool stats.
>
>
This sounds interesting. Dave, how would you envision the ethtool
interface for this? A new modifier to --statistics? Like: 'ethtool
--statistics ethX viewname' where viewname could maybe be passed to the
driver to allow arbitrary views? Or something else?
Steve.
next prev parent reply other threads:[~2010-03-31 19:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 18:52 [PATCH 0/6] updated cxgb4 submission Dimitris Michailidis
2010-03-30 18:52 ` [PATCH 1/6] cxgb4: Add register, message, and FW definitions Dimitris Michailidis
2010-03-30 18:52 ` [PATCH 2/6] cxgb4: Add HW and FW support code Dimitris Michailidis
2010-03-30 18:52 ` [PATCH 3/6] cxgb4: Add packet queues and packet DMA code Dimitris Michailidis
2010-03-30 18:52 ` [PATCH 4/6] cxgb4: Add remaining driver headers and L2T management Dimitris Michailidis
2010-03-30 18:52 ` [PATCH 5/6] cxgb4: Add main driver file and driver Makefile Dimitris Michailidis
2010-03-30 18:52 ` [PATCH 6/6] net: Hook up cxgb4 to Kconfig and Makefile Dimitris Michailidis
2010-03-30 21:19 ` [PATCH 5/6] cxgb4: Add main driver file and driver Makefile Stephen Hemminger
2010-03-31 1:34 ` Dimitris Michailidis
2010-03-31 5:50 ` David Miller
2010-03-31 19:31 ` Steve Wise [this message]
2010-03-31 21:13 ` David Miller
2010-04-01 0:19 ` Dimitris Michailidis
2010-04-01 0:24 ` David Miller
2010-04-01 1:34 ` Dimitris Michailidis
2010-04-01 2:18 ` David Miller
2010-03-30 21:09 ` [PATCH 1/6] cxgb4: Add register, message, and FW definitions Stephen Hemminger
2010-03-31 1:25 ` Dimitris Michailidis
-- strict thread matches above, loose matches on Subject: below --
2010-04-02 1:28 [PATCH 0/6] updated cxgb4 submission v6 Dimitris Michailidis
2010-04-02 1:28 ` [PATCH 1/6] cxgb4: Add register, message, and FW definitions Dimitris Michailidis
2010-04-02 1:28 ` [PATCH 2/6] cxgb4: Add HW and FW support code Dimitris Michailidis
2010-04-02 1:28 ` [PATCH 3/6] cxgb4: Add packet queues and packet DMA code Dimitris Michailidis
2010-04-02 1:28 ` [PATCH 4/6] cxgb4: Add remaining driver headers and L2T management Dimitris Michailidis
2010-04-02 1:28 ` [PATCH 5/6] cxgb4: Add main driver file and driver Makefile Dimitris Michailidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB3A301.3090100@opengridcomputing.com \
--to=swise@opengridcomputing.com \
--cc=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).