From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
shemminger@vyatta.com, bhutchings@solarflare.com,
andreas@fatal.se, hadi@cyberus.ca, hideaki@yoshifuji.org
Subject: Re: [PATCH] xtables: make XT_ALIGN() usable in exported headers by exporting __ALIGN_KERNEL()
Date: Tue, 13 Apr 2010 12:01:59 +0200 [thread overview]
Message-ID: <4BC44117.80901@trash.net> (raw)
In-Reply-To: <4BC437C6.8020602@trash.net>
Patrick McHardy wrote:
> Alexey Dobriyan wrote:
>> XT_ALIGN() was rewritten through ALIGN() by commit 42107f5009da223daa800d6da6904d77297ae829
>> "netfilter: xtables: symmetric COMPAT_XT_ALIGN definition".
>> ALIGN() is not exported in userspace headers, which created compile problem for tc(8)
>> and will create problem for iptables(8).
>>
>> We can't export generic looking name ALIGN() but we can export less generic
>> __ALIGN_KERNEL() (suggested by Ben Hutchings).
>> Google knows nothing about __ALIGN_KERNEL().
>>
>> COMPAT_XT_ALIGN() changed for symmetry.
>
> Since there haven't been any objections, I've applied your patch.
This breaks compilation by removing __ALIGN_MASK(). Please fix this up.
next prev parent reply other threads:[~2010-04-13 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 16:22 [PATCH] xtables: make XT_ALIGN() usable in exported headers by exporting __ALIGN_KERNEL() Alexey Dobriyan
2010-04-13 9:22 ` Patrick McHardy
2010-04-13 10:01 ` Patrick McHardy [this message]
2010-04-13 11:06 ` [PATCH v2] " Alexey Dobriyan
2010-04-13 11:08 ` Patrick McHardy
2010-04-13 11:50 ` Alexey Dobriyan
2010-04-13 12:10 ` Patrick McHardy
2010-04-13 11:50 ` Alexey Dobriyan
2010-04-13 11:06 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC44117.80901@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=andreas@fatal.se \
--cc=bhutchings@solarflare.com \
--cc=hadi@cyberus.ca \
--cc=hideaki@yoshifuji.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).