From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] xtables: make XT_ALIGN() usable in exported headers by exporting __ALIGN_KERNEL() Date: Tue, 13 Apr 2010 12:01:59 +0200 Message-ID: <4BC44117.80901@trash.net> References: <20100407162245.GA4557@x200> <4BC437C6.8020602@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, shemminger@vyatta.com, bhutchings@solarflare.com, andreas@fatal.se, hadi@cyberus.ca, hideaki@yoshifuji.org To: Alexey Dobriyan Return-path: In-Reply-To: <4BC437C6.8020602@trash.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Patrick McHardy wrote: > Alexey Dobriyan wrote: >> XT_ALIGN() was rewritten through ALIGN() by commit 42107f5009da223daa800d6da6904d77297ae829 >> "netfilter: xtables: symmetric COMPAT_XT_ALIGN definition". >> ALIGN() is not exported in userspace headers, which created compile problem for tc(8) >> and will create problem for iptables(8). >> >> We can't export generic looking name ALIGN() but we can export less generic >> __ALIGN_KERNEL() (suggested by Ben Hutchings). >> Google knows nothing about __ALIGN_KERNEL(). >> >> COMPAT_XT_ALIGN() changed for symmetry. > > Since there haven't been any objections, I've applied your patch. This breaks compilation by removing __ALIGN_MASK(). Please fix this up.