From: Ayaz Abdulla <aabdulla@nvidia.com>
To: David Miller <davem@davemloft.net>
Cc: "eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"smulcahy@gmail.com" <smulcahy@gmail.com>,
"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ben@decadent.org.uk" <ben@decadent.org.uk>,
"572201@bugs.debian.org" <572201@bugs.debian.org>
Subject: Bug#572201: [PATCH] forcedeth: fix tx limit2 flag check
Date: Wed, 14 Apr 2010 01:31:26 -0400 [thread overview]
Message-ID: <4BC5532E.7000302@nvidia.com> (raw)
In-Reply-To: <20100413.144340.138717714.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
This patch fixes the TX_LIMIT feature flag. The previous logic check for
TX_LIMIT2 also took into account a device that only had TX_LIMIT set.
Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
This is a fix for bug 572201 @ bugs.debian.org
[-- Attachment #2: patch-forcedeth-tx-limit2-fix --]
[-- Type: text/plain, Size: 462 bytes --]
--- old/drivers/net/forcedeth.c 2010-04-14 01:18:51.000000000 -0400
+++ new/drivers/net/forcedeth.c 2010-04-14 01:20:40.000000000 -0400
@@ -5901,7 +5901,7 @@
/* Limit the number of tx's outstanding for hw bug */
if (id->driver_data & DEV_NEED_TX_LIMIT) {
np->tx_limit = 1;
- if ((id->driver_data & DEV_NEED_TX_LIMIT2) &&
+ if (((id->driver_data & DEV_NEED_TX_LIMIT2) == DEV_NEED_TX_LIMIT2) &&
pci_dev->revision >= 0xA2)
np->tx_limit = 0;
}
next prev parent reply other threads:[~2010-04-14 5:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B9E6C60.7030300@atlanticlinux.ie>
[not found] ` <20100315182220.GQ2763@decadent.org.uk>
[not found] ` <4B9F5E5E.2060209@atlanticlinux.ie>
[not found] ` <1270393967.8341.11.camel@localhost>
[not found] ` <4BBCA19C.5080204@atlanticlinux.ie>
2010-04-10 23:36 ` forcedeth driver hangs under heavy load Ben Hutchings
2010-04-12 10:01 ` Bug#572201: " stephen mulcahy
2010-04-12 12:39 ` stephen mulcahy
2010-04-12 12:47 ` Eric Dumazet
2010-04-12 13:05 ` stephen mulcahy
2010-04-12 13:19 ` stephen mulcahy
2010-04-12 15:24 ` Eric Dumazet
2010-04-12 16:11 ` stephen mulcahy
2010-04-12 16:59 ` Eric Dumazet
2010-04-13 10:03 ` stephen mulcahy
2010-04-13 10:49 ` Eric Dumazet
2010-04-13 11:00 ` stephen mulcahy
2010-04-13 12:04 ` Ben Hutchings
2010-04-13 14:27 ` stephen mulcahy
2010-04-13 14:42 ` Eric Dumazet
2010-04-13 14:49 ` stephen mulcahy
2010-04-13 15:00 ` stephen mulcahy
2010-04-13 15:05 ` Eric Dumazet
2010-04-13 15:08 ` stephen mulcahy
2010-04-13 15:22 ` Eric Dumazet
2010-04-13 15:25 ` stephen mulcahy
2010-04-13 20:01 ` Eric Dumazet
2010-04-13 21:43 ` David Miller
2010-04-13 21:46 ` Eric Dumazet
2010-04-14 5:33 ` Bug#572201: " Ayaz Abdulla
2010-04-14 1:41 ` David Miller
2010-04-14 14:30 ` stephen mulcahy
2010-04-14 5:31 ` Ayaz Abdulla [this message]
2010-04-14 10:14 ` [PATCH] forcedeth: fix tx limit2 flag check stephen mulcahy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC5532E.7000302@nvidia.com \
--to=aabdulla@nvidia.com \
--cc=572201@bugs.debian.org \
--cc=ben@decadent.org.uk \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=smulcahy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).