From: Dimitris Michailidis <dm@chelsio.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: cxgb4: Use ntohs() on __be16 value instead of htons()
Date: Wed, 21 Apr 2010 12:17:43 -0700 [thread overview]
Message-ID: <4BCF4F57.4050802@chelsio.com> (raw)
In-Reply-To: <ada1ve8r832.fsf@roland-alpha.cisco.com>
On 04/21/2010 11:09 AM, Roland Dreier wrote:
> Use the correct direction of byte-swapping function to fix a mistake
> shown by sparse endianness checking -- c.fl0id is __be16.
>
> Signed-off-by: Roland Dreier<rolandd@cisco.com>
Yes, thanks.
Acked-by: Dimitris Michailidis <dm@chelsio.com>
> ---
> drivers/net/cxgb4/sge.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/cxgb4/sge.c b/drivers/net/cxgb4/sge.c
> index 14adc58..70bf2b2 100644
> --- a/drivers/net/cxgb4/sge.c
> +++ b/drivers/net/cxgb4/sge.c
> @@ -2047,7 +2047,7 @@ int t4_sge_alloc_rxq(struct adapter *adap, struct sge_rspq *iq, bool fwevtq,
> adap->sge.ingr_map[iq->cntxt_id] = iq;
>
> if (fl) {
> - fl->cntxt_id = htons(c.fl0id);
> + fl->cntxt_id = ntohs(c.fl0id);
> fl->avail = fl->pend_cred = 0;
> fl->pidx = fl->cidx = 0;
> fl->alloc_failed = fl->large_alloc_failed = fl->starving = 0;
>
next prev parent reply other threads:[~2010-04-21 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 18:09 cxgb4: Use ntohs() on __be16 value instead of htons() Roland Dreier
2010-04-21 19:17 ` Dimitris Michailidis [this message]
2010-04-22 6:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCF4F57.4050802@chelsio.com \
--to=dm@chelsio.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox