From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@linux.intel.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] e100: Fix the TX workqueue race
Date: Fri, 23 Apr 2010 12:20:42 -0400 [thread overview]
Message-ID: <4BD1C8DA.4050002@garzik.org> (raw)
In-Reply-To: <20100423143356.7092.45260.stgit@localhost.localdomain>
On 04/23/2010 10:34 AM, Alan Cox wrote:
> I'd assumed someone would have picked up on this and fixed it using rtnl_lock
> as was suggested but it seems to have fallen through the cracks ?
>
> Anyway this is I assume what was meant ?
>
> ---
>
> Nothing stops the workqueue being left to run in parallel with close or a
> few other operations. This causes double unmaps and the like.
>
> See kerneloops.org #1041230 for an example
>
> Signed-off-by: Alan Cox<alan@linux.intel.com>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
Glad someone finally fixed this, it has bugged me for years...
------------------------------------------------------------------------------
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2010-04-23 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 14:34 [PATCH] e100: Fix the TX workqueue race Alan Cox
2010-04-23 16:20 ` Jeff Garzik [this message]
2010-04-23 23:31 ` David Miller
2010-04-23 23:35 ` David Miller
2010-04-24 10:36 ` Alan Cox
2010-04-25 3:00 ` David Miller
2010-04-24 11:11 ` Alan Cox
2010-04-25 2:58 ` David Miller
2010-04-25 4:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD1C8DA.4050002@garzik.org \
--to=jeff@garzik.org \
--cc=alan@linux.intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).