From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] e100: Fix the TX workqueue race Date: Fri, 23 Apr 2010 12:20:42 -0400 Message-ID: <4BD1C8DA.4050002@garzik.org> References: <20100423143356.7092.45260.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org To: Alan Cox Return-path: In-Reply-To: <20100423143356.7092.45260.stgit@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On 04/23/2010 10:34 AM, Alan Cox wrote: > I'd assumed someone would have picked up on this and fixed it using rtnl_lock > as was suggested but it seems to have fallen through the cracks ? > > Anyway this is I assume what was meant ? > > --- > > Nothing stops the workqueue being left to run in parallel with close or a > few other operations. This causes double unmaps and the like. > > See kerneloops.org #1041230 for an example > > Signed-off-by: Alan Cox Acked-by: Jeff Garzik Glad someone finally fixed this, it has bugged me for years... ------------------------------------------------------------------------------ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired