* Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] [not found] ` <4BD45E68.4080900@example.com> @ 2010-04-25 16:31 ` Sedat Dilek 2010-04-25 16:36 ` Piotr Hosowicz 0 siblings, 1 reply; 7+ messages in thread From: Sedat Dilek @ 2010-04-25 16:31 UTC (permalink / raw) To: piotr; +Cc: LKML, netdev, David Miller, Jiri Olsa, Eric Dumazet, Jongman Heo [ CCing netdev ML ] Confirmed: The revert-patch [1] fixes the problem here. See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. Feel free to add a... Tested-by: Sedat Dilek <sedat.dilek@gmail.com> - Sedat - [1] https://patchwork.kernel.org/patch/94959/ [2] https://bugzilla.kernel.org/show_bug.cgi?id=15847 2010/4/25 Piotr Hosowicz <piotr@hosowicz.com>: > On 25.04.2010 17:11, Sedat Dilek wrote: >> >> [ Please CC - I am not subscribed to LKML ] >> >> [QUOTE] >> >> On 25.04.2010 16:26, Jongman Heo wrote: >> >>> I also hit this bug today. >> >> I also hit similar bug, maybe it is the same. >> >>> Doing git bisect, first bad commit was >>> >>> commit fda48a0d7a8412cedacda46a9c0bf8ef9cd13559 >>> tcp: bind() fix when many ports are bound >>> >>> Reverting above commit fixes the problem. >> >> How to do it? Would you please publish a reverting patch? >> >> Regards, >> >> Piotr Hosowicz >> >> [/QUOTE] >> >> Hi, >> >> did forget to mention 2.6.34-rc5-git5 was OK. >> >> Revering this commit did not help: >> >> commit f4f914b58019f0e50d521bbbadfaee260d766f95 >> net: ipv6 bind to device issue >> >> After looking into net-2.6 GIT repository, "tcp: bind() fix when many >> ports are bound" could cause indeed the problems here, too. >> Building now.... >> >> Regards, >> - Sedat - >> >> P.S.: Attached 0001-Revert-tcp-bind-fix-when-many-ports-are-bound.patch > > Thanks a lot. Applied and building now. > > Regards, > > Piotr Hosowicz > > -- > Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach: > - W którym kraju znajduje się Mount Everest? > - Hm, to nie Szkocja, prawda? > NP: Mark Knopfler - Cleaning My Gun > NB: 2.6.34-rc5-git5 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] 2010-04-25 16:31 ` [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] Sedat Dilek @ 2010-04-25 16:36 ` Piotr Hosowicz 2010-04-25 16:39 ` Eric Dumazet 0 siblings, 1 reply; 7+ messages in thread From: Piotr Hosowicz @ 2010-04-25 16:36 UTC (permalink / raw) To: sedat.dilek Cc: Sedat Dilek, LKML, netdev, David Miller, Jiri Olsa, Eric Dumazet, Jongman Heo On 25.04.2010 18:31, Sedat Dilek wrote: > [ CCing netdev ML ] > > Confirmed: The revert-patch [1] fixes the problem here. I confirm, I've built a git6 kernel and it works fine. > See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. > > Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> I added created and tested phrase in my archive. ;-) Thank you a lot. I hope there will be no this error in git7. Regards, Piotr Hosowicz > - Sedat - > > [1] https://patchwork.kernel.org/patch/94959/ > [2] https://bugzilla.kernel.org/show_bug.cgi?id=15847 > > 2010/4/25 Piotr Hosowicz<piotr@hosowicz.com>: >> On 25.04.2010 17:11, Sedat Dilek wrote: >>> >>> [ Please CC - I am not subscribed to LKML ] >>> >>> [QUOTE] >>> >>> On 25.04.2010 16:26, Jongman Heo wrote: >>> >>>> I also hit this bug today. >>> >>> I also hit similar bug, maybe it is the same. >>> >>>> Doing git bisect, first bad commit was >>>> >>>> commit fda48a0d7a8412cedacda46a9c0bf8ef9cd13559 >>>> tcp: bind() fix when many ports are bound >>>> >>>> Reverting above commit fixes the problem. >>> >>> How to do it? Would you please publish a reverting patch? >>> >>> Regards, >>> >>> Piotr Hosowicz >>> >>> [/QUOTE] >>> >>> Hi, >>> >>> did forget to mention 2.6.34-rc5-git5 was OK. >>> >>> Revering this commit did not help: >>> >>> commit f4f914b58019f0e50d521bbbadfaee260d766f95 >>> net: ipv6 bind to device issue >>> >>> After looking into net-2.6 GIT repository, "tcp: bind() fix when many >>> ports are bound" could cause indeed the problems here, too. >>> Building now.... >>> >>> Regards, >>> - Sedat - >>> >>> P.S.: Attached 0001-Revert-tcp-bind-fix-when-many-ports-are-bound.patch >> >> Thanks a lot. Applied and building now. >> >> Regards, >> >> Piotr Hosowicz >> >> -- >> Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach: >> - W którym kraju znajduje się Mount Everest? >> - Hm, to nie Szkocja, prawda? >> NP: Mark Knopfler - Cleaning My Gun >> NB: 2.6.34-rc5-git5 >> > -- Grupa marzeń w eliminacjach MŚ : Zimbabwe, Alaska, Grenlandia, Antarktyda i Zair. NP: Chickenfoot - Oh Yeah NB: 2.6.34-rc5-git6 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] 2010-04-25 16:36 ` Piotr Hosowicz @ 2010-04-25 16:39 ` Eric Dumazet 2010-04-25 16:55 ` Sedat Dilek 0 siblings, 1 reply; 7+ messages in thread From: Eric Dumazet @ 2010-04-25 16:39 UTC (permalink / raw) To: piotr Cc: sedat.dilek, Sedat Dilek, LKML, netdev, David Miller, Jiri Olsa, Jongman Heo Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : > On 25.04.2010 18:31, Sedat Dilek wrote: > > [ CCing netdev ML ] > > > > Confirmed: The revert-patch [1] fixes the problem here. > > I confirm, I've built a git6 kernel and it works fine. > > > See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. > > > > Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> > > I added created and tested phrase in my archive. ;-) Thank you a lot. I > hope there will be no this error in git7. > Did you test the proposed fix ? [PATCH] ipv6: Fix inet6_csk_bind_conflict() Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) introduced a bug on IPV6 part. We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is IPV6. Reported-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c index b4b7d40..3a4d92b 100644 --- a/net/ipv6/inet6_connection_sock.c +++ b/net/ipv6/inet6_connection_sock.c @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, ipv6_rcv_saddr_equal(sk, sk2)) break; else if (sk->sk_reuse && sk2->sk_reuse && - !ipv6_addr_any(inet6_rcv_saddr(sk2)) && + !ipv6_addr_any(inet6_rcv_saddr(sk)) && ipv6_rcv_saddr_equal(sk, sk2)) break; } ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] 2010-04-25 16:39 ` Eric Dumazet @ 2010-04-25 16:55 ` Sedat Dilek 2010-04-25 17:01 ` Piotr Hosowicz 0 siblings, 1 reply; 7+ messages in thread From: Sedat Dilek @ 2010-04-25 16:55 UTC (permalink / raw) To: Eric Dumazet; +Cc: piotr, LKML, netdev, David Miller, Jiri Olsa, Jongman Heo [-- Attachment #1: Type: text/plain, Size: 2241 bytes --] Rebuild ipv6 kernel-modules by: $ make M=net/ipv6 ...and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually to the right place. Applied your patch (seen on netdev ML) already and booted into new kernel. Works, thanks. Tested-by: Sedat Dilek <sedat.dilek@gmail.com> - Sedat - On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : >> On 25.04.2010 18:31, Sedat Dilek wrote: >> > [ CCing netdev ML ] >> > >> > Confirmed: The revert-patch [1] fixes the problem here. >> >> I confirm, I've built a git6 kernel and it works fine. >> >> > See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. >> > >> > Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> >> >> I added created and tested phrase in my archive. ;-) Thank you a lot. I >> hope there will be no this error in git7. >> > > Did you test the proposed fix ? > > > [PATCH] ipv6: Fix inet6_csk_bind_conflict() > > Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) > introduced a bug on IPV6 part. > We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but > ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is > IPV6. > > Reported-by: Michael S. Tsirkin <mst@redhat.com> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > --- > diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c > index b4b7d40..3a4d92b 100644 > --- a/net/ipv6/inet6_connection_sock.c > +++ b/net/ipv6/inet6_connection_sock.c > @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, > ipv6_rcv_saddr_equal(sk, sk2)) > break; > else if (sk->sk_reuse && sk2->sk_reuse && > - !ipv6_addr_any(inet6_rcv_saddr(sk2)) && > + !ipv6_addr_any(inet6_rcv_saddr(sk)) && > ipv6_rcv_saddr_equal(sk, sk2)) > break; > } > > > [-- Attachment #2: ipv6-Fix-inet6_csk_bind_conflict.patch --] [-- Type: text/x-diff, Size: 882 bytes --] [PATCH] ipv6: Fix inet6_csk_bind_conflict() Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) introduced a bug on IPV6 part. We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is IPV6. Reported-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c index b4b7d40..3a4d92b 100644 --- a/net/ipv6/inet6_connection_sock.c +++ b/net/ipv6/inet6_connection_sock.c @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, ipv6_rcv_saddr_equal(sk, sk2)) break; else if (sk->sk_reuse && sk2->sk_reuse && - !ipv6_addr_any(inet6_rcv_saddr(sk2)) && + !ipv6_addr_any(inet6_rcv_saddr(sk)) && ipv6_rcv_saddr_equal(sk, sk2)) break; } ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] 2010-04-25 16:55 ` Sedat Dilek @ 2010-04-25 17:01 ` Piotr Hosowicz 2010-04-25 17:08 ` Eric Dumazet 2010-04-25 17:25 ` Sedat Dilek 0 siblings, 2 replies; 7+ messages in thread From: Piotr Hosowicz @ 2010-04-25 17:01 UTC (permalink / raw) To: sedat.dilek Cc: Sedat Dilek, Eric Dumazet, LKML, netdev, David Miller, Jiri Olsa, Jongman Heo On 25.04.2010 18:55, Sedat Dilek wrote: > Rebuild ipv6 kernel-modules by: > > $ make M=net/ipv6 > > ...and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually > to the right place. > > Applied your patch (seen on netdev ML) already and booted into new kernel. > Works, thanks. > > Tested-by: Sedat Dilek<sedat.dilek@gmail.com> > > - Sedat - > > On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet<eric.dumazet@gmail.com> wrote: >> Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : >>> On 25.04.2010 18:31, Sedat Dilek wrote: >>>> [ CCing netdev ML ] >>>> >>>> Confirmed: The revert-patch [1] fixes the problem here. >>> >>> I confirm, I've built a git6 kernel and it works fine. >>> >>>> See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. >>>> >>>> Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> >>> >>> I added created and tested phrase in my archive. ;-) Thank you a lot. I >>> hope there will be no this error in git7. >>> >> >> Did you test the proposed fix ? Eric, but where to get the proposed fix as a patch? I looked at kernel's bugzilla and there is no such thing. As for now I applied Sedat's reverse patch and now I am booted fine in git6 kernel. Regards, Piotr Hosowicz >> [PATCH] ipv6: Fix inet6_csk_bind_conflict() >> >> Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) >> introduced a bug on IPV6 part. >> We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but >> ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is >> IPV6. >> >> Reported-by: Michael S. Tsirkin<mst@redhat.com> >> Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com> >> --- >> diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c >> index b4b7d40..3a4d92b 100644 >> --- a/net/ipv6/inet6_connection_sock.c >> +++ b/net/ipv6/inet6_connection_sock.c >> @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, >> ipv6_rcv_saddr_equal(sk, sk2)) >> break; >> else if (sk->sk_reuse&& sk2->sk_reuse&& >> - !ipv6_addr_any(inet6_rcv_saddr(sk2))&& >> + !ipv6_addr_any(inet6_rcv_saddr(sk))&& >> ipv6_rcv_saddr_equal(sk, sk2)) >> break; >> } >> >> >> -- "Bardzo fajna firma, tylko czasami nie płaci. Do jej głównych zalet należą: ekspres ciśnieniowy (ale tylko na jednym z pię- ter) oraz fajne widoki z salki konferencyjnej. No i jakieś pół roku temu odeszło 90% pracowników działu IT, ale może nie mieli racji ;)" NP: Chickenfoot - Soap On A Rope NB: 2.6.34-rc5-git6 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] 2010-04-25 17:01 ` Piotr Hosowicz @ 2010-04-25 17:08 ` Eric Dumazet 2010-04-25 17:25 ` Sedat Dilek 1 sibling, 0 replies; 7+ messages in thread From: Eric Dumazet @ 2010-04-25 17:08 UTC (permalink / raw) To: piotr Cc: sedat.dilek, Sedat Dilek, LKML, netdev, David Miller, Jiri Olsa, Jongman Heo Le dimanche 25 avril 2010 à 19:01 +0200, Piotr Hosowicz a écrit : > On 25.04.2010 18:55, Sedat Dilek wrote: > > Rebuild ipv6 kernel-modules by: > > > > $ make M=net/ipv6 > > > > ...and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually > > to the right place. > > > > Applied your patch (seen on netdev ML) already and booted into new kernel. > > Works, thanks. > > > > Tested-by: Sedat Dilek<sedat.dilek@gmail.com> > > > > - Sedat - > > > > On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet<eric.dumazet@gmail.com> wrote: > >> Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : > >>> On 25.04.2010 18:31, Sedat Dilek wrote: > >>>> [ CCing netdev ML ] > >>>> > >>>> Confirmed: The revert-patch [1] fixes the problem here. > >>> > >>> I confirm, I've built a git6 kernel and it works fine. > >>> > >>>> See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. > >>>> > >>>> Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> > >>> > >>> I added created and tested phrase in my archive. ;-) Thank you a lot. I > >>> hope there will be no this error in git7. > >>> > >> > >> Did you test the proposed fix ? > > Eric, but where to get the proposed fix as a patch? I looked at kernel's > bugzilla and there is no such thing. As for now I applied Sedat's > reverse patch and now I am booted fine in git6 kernel. > I wont spend my Sunday time at filling bugzilla entries. I sent a patch on netdev. I finaly could test it (I have a very slow machine while traveling, and compiling the thing took a *lot* of time) Now back to family affairs ;) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] 2010-04-25 17:01 ` Piotr Hosowicz 2010-04-25 17:08 ` Eric Dumazet @ 2010-04-25 17:25 ` Sedat Dilek 1 sibling, 0 replies; 7+ messages in thread From: Sedat Dilek @ 2010-04-25 17:25 UTC (permalink / raw) To: piotr; +Cc: Eric Dumazet, LKML, netdev, David Miller, Jiri Olsa, Jongman Heo On Sun, Apr 25, 2010 at 7:01 PM, Piotr Hosowicz <piotr@hosowicz.com> wrote: > On 25.04.2010 18:55, Sedat Dilek wrote: >> [...] >> On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet<eric.dumazet@gmail.com> >> wrote: >>> >>> Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : >>>> >>>> On 25.04.2010 18:31, Sedat Dilek wrote: >>>>> >>>>> [ CCing netdev ML ] >>>>> >>>>> Confirmed: The revert-patch [1] fixes the problem here. >>>> >>>> I confirm, I've built a git6 kernel and it works fine. >>>> >>>>> See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. >>>>> >>>>> Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> >>>> >>>> I added created and tested phrase in my archive. ;-) Thank you a lot. I >>>> hope there will be no this error in git7. >>>> >>> >>> Did you test the proposed fix ? > > Eric, but where to get the proposed fix as a patch? I looked at kernel's > bugzilla and there is no such thing. As for now I applied Sedat's reverse > patch and now I am booted fine in git6 kernel. > > Regards, > > Piotr Hosowicz > For easy catching proposed patched to LKML look at <patchwork.kernel.org> [1]. There you find other mailing-lists and further patches. Cut-N-Paste excerpts of Eric's email should also work :-). - Sedat - [1] https://patchwork.kernel.org/project/LKML/list/ [2] https://patchwork.kernel.org/patch/94961/ ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-04-25 17:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <l2z2d0a357f1004250811w6da355ebp95d1730473026c22@mail.gmail.com>
[not found] ` <4BD45E68.4080900@example.com>
2010-04-25 16:31 ` [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] Sedat Dilek
2010-04-25 16:36 ` Piotr Hosowicz
2010-04-25 16:39 ` Eric Dumazet
2010-04-25 16:55 ` Sedat Dilek
2010-04-25 17:01 ` Piotr Hosowicz
2010-04-25 17:08 ` Eric Dumazet
2010-04-25 17:25 ` Sedat Dilek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox