* [PATCH] cxgb3: Wait longer for control packets on initialization
@ 2010-04-26 15:38 Andre Detsch
2010-04-27 2:16 ` Divy Le Ray
0 siblings, 1 reply; 3+ messages in thread
From: Andre Detsch @ 2010-04-26 15:38 UTC (permalink / raw)
To: netdev, divy
In some Power7 platforms, when using VIOS (Virtual I/O Server), we
need to wait longer for control packets to finish transfer during
initialization.
Without this change, initialization may fail prematurely.
Signed-off-by: Wen Xiong <wenxiong@us.ibm.com>
Signed-off-by: Andre Detsch <adetsch@br.ibm.com>
Index: linux-2.6.34-rc5/drivers/net/cxgb3/cxgb3_main.c
===================================================================
--- linux-2.6.34-rc5.orig/drivers/net/cxgb3/cxgb3_main.c 2010-04-23 18:59:43.000000000 -0300
+++ linux-2.6.34-rc5/drivers/net/cxgb3/cxgb3_main.c 2010-04-23 18:59:55.000000000 -0300
@@ -439,7 +439,7 @@ static void free_irq_resources(struct ad
static int await_mgmt_replies(struct adapter *adap, unsigned long init_cnt,
unsigned long n)
{
- int attempts = 5;
+ int attempts = 10;
while (adap->sge.qs[0].rspq.offload_pkts < init_cnt + n) {
if (!--attempts)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cxgb3: Wait longer for control packets on initialization
2010-04-26 15:38 [PATCH] cxgb3: Wait longer for control packets on initialization Andre Detsch
@ 2010-04-27 2:16 ` Divy Le Ray
2010-04-27 17:18 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Divy Le Ray @ 2010-04-27 2:16 UTC (permalink / raw)
To: Andre Detsch; +Cc: netdev
Andre Detsch wrote:
> In some Power7 platforms, when using VIOS (Virtual I/O Server), we
> need to wait longer for control packets to finish transfer during
> initialization.
> Without this change, initialization may fail prematurely.
>
> Signed-off-by: Wen Xiong <wenxiong@us.ibm.com>
> Signed-off-by: Andre Detsch <adetsch@br.ibm.com>
>
Acked-by: Divy Le Ray <divy@chelsio.com>
> Index: linux-2.6.34-rc5/drivers/net/cxgb3/cxgb3_main.c
> ===================================================================
> --- linux-2.6.34-rc5.orig/drivers/net/cxgb3/cxgb3_main.c 2010-04-23 18:59:43.000000000 -0300
> +++ linux-2.6.34-rc5/drivers/net/cxgb3/cxgb3_main.c 2010-04-23 18:59:55.000000000 -0300
> @@ -439,7 +439,7 @@ static void free_irq_resources(struct ad
> static int await_mgmt_replies(struct adapter *adap, unsigned long init_cnt,
> unsigned long n)
> {
> - int attempts = 5;
> + int attempts = 10;
>
> while (adap->sge.qs[0].rspq.offload_pkts < init_cnt + n) {
> if (!--attempts)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cxgb3: Wait longer for control packets on initialization
2010-04-27 2:16 ` Divy Le Ray
@ 2010-04-27 17:18 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-04-27 17:18 UTC (permalink / raw)
To: divy; +Cc: adetsch, netdev
From: Divy Le Ray <divy@chelsio.com>
Date: Mon, 26 Apr 2010 19:16:28 -0700
> Andre Detsch wrote:
>> In some Power7 platforms, when using VIOS (Virtual I/O Server), we
>> need to wait longer for control packets to finish transfer during
>> initialization.
>> Without this change, initialization may fail prematurely.
>>
>> Signed-off-by: Wen Xiong <wenxiong@us.ibm.com>
>> Signed-off-by: Andre Detsch <adetsch@br.ibm.com>
>>
>
> Acked-by: Divy Le Ray <divy@chelsio.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-27 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-26 15:38 [PATCH] cxgb3: Wait longer for control packets on initialization Andre Detsch
2010-04-27 2:16 ` Divy Le Ray
2010-04-27 17:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).