From: Cong Wang <amwang@redhat.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Octavian Purdila <opurdila@ixiacom.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
penguin-kernel@i-love.sakura.ne.jp, netdev@vger.kernel.org,
Neil Horman <nhorman@tuxdriver.com>,
ebiederm@xmission.com, David Miller <davem@davemloft.net>,
adobriyan@gmail.com
Subject: Re: [Patch 1/3] sysctl: refactor integer handling proc code
Date: Wed, 05 May 2010 11:02:24 +0800 [thread overview]
Message-ID: <4BE0DFC0.30309@redhat.com> (raw)
In-Reply-To: <u2s412e6f7f1004301549tb0e88a80n4c621e42c0b31015@mail.gmail.com>
Changli Gao wrote:
> On Fri, Apr 30, 2010 at 4:25 PM, Amerigo Wang <amwang@redhat.com> wrote:
>> + if (*p == '-' && *size > 1) {
>> + *neg = 1;
>
> As neg is bool*, you should use true and false instead of 1 and 0.
>
Yeah, I only corrected those lines that I touched, I should
correct them all.
Will fix.
Thanks.
next prev parent reply other threads:[~2010-05-05 2:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 8:25 [Patch v9 0/3] net: reserve ports for applications using fixed port numbers Amerigo Wang
2010-04-30 8:25 ` [Patch 1/3] sysctl: refactor integer handling proc code Amerigo Wang
2010-04-30 22:49 ` Changli Gao
2010-05-05 3:02 ` Cong Wang [this message]
2010-04-30 8:25 ` [Patch 2/3] sysctl: add proc_do_large_bitmap Amerigo Wang
2010-04-30 22:41 ` Changli Gao
2010-05-05 3:14 ` Cong Wang
2010-05-05 9:20 ` Cong Wang
2010-04-30 8:25 ` [Patch 3/3] net: reserve ports for applications using fixed port numbers Amerigo Wang
-- strict thread matches above, loose matches on Subject: below --
2010-05-05 10:26 [Patch v10 0/3] " Amerigo Wang
2010-05-05 10:26 ` [Patch 1/3] sysctl: refactor integer handling proc code Amerigo Wang
2010-04-12 10:03 [Patch v8 0/3] net: reserve ports for applications using fixed port numbers Amerigo Wang
2010-04-12 10:04 ` [Patch 1/3] sysctl: refactor integer handling proc code Amerigo Wang
2010-04-12 10:18 ` Alexey Dobriyan
2010-04-13 7:35 ` Cong Wang
2010-04-12 10:18 ` Alexey Dobriyan
2010-04-09 10:10 [Patch v7 0/3] net: reserve ports for applications using fixed port numbers Amerigo Wang
2010-04-09 10:11 ` [Patch 1/3] sysctl: refactor integer handling proc code Amerigo Wang
2010-04-09 10:49 ` Changli Gao
2010-04-09 13:40 ` Octavian Purdila
2010-04-12 6:30 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE0DFC0.30309@redhat.com \
--to=amwang@redhat.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=opurdila@ixiacom.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).