netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Meissner <andreas.meissner@indakom.de>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: [PATCH] IPv4: unresolved multicast route cleanup
Date: Mon, 10 May 2010 11:09:33 +0200	[thread overview]
Message-ID: <4BE7CD4D.6050704@indakom.de> (raw)

from: Andreas Meissner <andreas.meissner@sphairon.com>

Fixes the expiration timer for unresolved multicast route entries.
In case new multicast routing requests come in faster than the 
expiration timeout occurs (e.g. zap through multicast TV streams), the 
timer is prevented from being called at time for already existing entries.

Signed-off by: Andreas Meissner <andreas.meissner@sphairon.com>
---
As the single timer is resetted to default whenever a new entry is made, 
the timeout for existing unresolved entires are missed and/or not 
updated. As a consequence new requests are denied when the limit of 
unresolved entries has been reached because old entries live longer than 
they are supposed to.
The solution is to reset the timer only for the first unresolved entry 
in the multicast routing cache. All other timers are already set and 
updated correctly within the timer function itself by now.
---
 ipv4/ipmr.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
--- net/ipv4/ipmr.c.orig	2010-05-10 10:07:38.000000000 +0200
+++ net/ipv4/ipmr.c	2010-05-10 10:08:39.000000000 +0200
@@ -753,7 +753,8 @@
 		c->next = mfc_unres_queue;
 		mfc_unres_queue = c;
 
-		mod_timer(&ipmr_expire_timer, c->mfc_un.unres.expires);
+		if (atomic_read(&net->ipv4.cache_resolve_queue_len) == 1)
+			mod_timer(&ipmr_expire_timer, c->mfc_un.unres.expires);
 	}
 
 	/*


             reply	other threads:[~2010-05-10  9:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10  9:09 Andreas Meissner [this message]
2010-05-10 11:48 ` [PATCH] IPv4: unresolved multicast route cleanup David Miller
  -- strict thread matches above, loose matches on Subject: below --
2010-05-03  9:47 Andreas Meißner
2010-05-03 22:41 ` David Miller
2010-05-10  8:40   ` Andreas Meissner
2010-05-10  9:04     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE7CD4D.6050704@indakom.de \
    --to=andreas.meissner@indakom.de \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).