From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: Re: [PATCH 2/3] cxgb4i_v3: main driver files Date: Thu, 27 May 2010 02:40:52 -0500 Message-ID: <4BFE2204.3020502@cs.wisc.edu> References: <1273944249-311-1-git-send-email-rakesh@chelsio.com> <1273944249-311-2-git-send-email-rakesh@chelsio.com> <1273944249-311-3-git-send-email-rakesh@chelsio.com> <4BFE2173.4050306@cs.wisc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Rakesh Ranjan , NETDEVML , SCSIDEVML , LKML , Karen Xie , David Miller , James Bottomley , Anish Bhatt , Rakesh Ranjan To: open-iscsi@googlegroups.com Return-path: Received: from sabe.cs.wisc.edu ([128.105.6.20]:46398 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852Ab0E0HjT (ORCPT ); Thu, 27 May 2010 03:39:19 -0400 In-Reply-To: <4BFE2173.4050306@cs.wisc.edu> Sender: netdev-owner@vger.kernel.org List-ID: On 05/27/2010 02:38 AM, Mike Christie wrote: > On 05/15/2010 12:24 PM, Rakesh Ranjan wrote: >> From: Rakesh Ranjan >> >> >> Signed-off-by: Rakesh Ranjan >> --- >> drivers/scsi/cxgb4i/cxgb4i.h | 101 ++ >> drivers/scsi/cxgb4i/cxgb4i_ddp.c | 678 +++++++++++++ >> drivers/scsi/cxgb4i/cxgb4i_ddp.h | 118 +++ >> drivers/scsi/cxgb4i/cxgb4i_offload.c | 1846 >> ++++++++++++++++++++++++++++++++++ >> drivers/scsi/cxgb4i/cxgb4i_offload.h | 91 ++ >> drivers/scsi/cxgb4i/cxgb4i_snic.c | 260 +++++ >> 6 files changed, 3094 insertions(+), 0 deletions(-) >> create mode 100644 drivers/scsi/cxgb4i/cxgb4i.h >> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_ddp.c >> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_ddp.h >> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_offload.c >> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_offload.h >> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_snic.c > > > > Got some whitespace errors when applying. > > warning: squelched 1 whitespace error > warning: 6 lines add whitespace errors. > > Oh yeah, run sparse on the driver too. There are some warnings about some functions should be static.