netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Olędzki" <ole@ans.pl>
To: Yaniv Rosner <yanivr@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
Date: Sun, 13 Jun 2010 23:27:55 +0200	[thread overview]
Message-ID: <4C154D5B.8000004@ans.pl> (raw)
In-Reply-To: <1276429385.13056.13.camel@lb-tlvb-yanivr.il.broadcom.com>

On 2010-06-13 13:43, Yaniv Rosner wrote:
> Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
>
> Reported-by: Krzysztof Oldzki <ole@ans.pl>
> Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> ---
> diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
> index a22a7e0..9b15b64 100644
> --- a/drivers/net/bnx2x_link.c
> +++ b/drivers/net/bnx2x_link.c
> @@ -4274,7 +4274,7 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
>   				       ext_phy_addr,
>   				       MDIO_PMA_DEVAD,
>   				       MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
> -				       0xa001);
> +				       0xa101);
>
>   			/* Set TX PreEmphasis if needed */
>   			if ((params->feature_config_flags&

Tested-by: Krzysztof Piotr Oledzki <ole@ans.pl>

However, I believe the comment before this code should also be changed, 
because it is now: "Set 2-wire transfer rate to 400Khz since 100Khz
is not operational ".

Thanks.

Best regards,

			Krzysztof Olędzki

  reply	other threads:[~2010-06-13 21:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-13 11:43 [net-next PATCH] bnx2x: Fix link problem with some DACs Yaniv Rosner
2010-06-13 21:27 ` Krzysztof Olędzki [this message]
2010-06-14  0:52   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2010-06-14 10:26 Yaniv Rosner
2010-06-14  8:49 ` Simon Horman
2010-06-14  9:04   ` Yaniv Rosner
2010-06-14  9:18     ` Simon Horman
2010-06-15  6:07 ` David Miller
2010-06-15  6:12   ` Yaniv Rosner
2010-06-15  8:22 Yaniv Rosner
2010-06-15  6:25 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C154D5B.8000004@ans.pl \
    --to=ole@ans.pl \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yanivr@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).