From: "Bruce Rogers" <brogers@novell.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: <rusty@rustcorp.com.au>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] KVM: add schedule check to napi_enable call
Date: Mon, 14 Jun 2010 14:44:17 -0600 [thread overview]
Message-ID: <4C16404102000048000980A8@sinclair.provo.novell.com> (raw)
In-Reply-To: <20100606094048.GA1979@gondor.apana.org.au>
>>> On 6/6/2010 at 03:40 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Bruce Rogers <brogers@novell.com> wrote:
>> Please consider this patch for the 2.6.32, 2.6.33, and 2.6.34 stable trees
> as well as current development trees. (I've only tested on 2.6.32 however)
>>
>> virtio_net: Add schedule check to napi_enable call
>> Under harsh testing conditions, including low memory, the guest would
>> stop receiving packets. With this patch applied we no longer see any
>> problems in the driver while performing these tests for extended periods
>> of time.
>>
>> Make sure napi is scheduled subsequent to each napi_enable.
>>
>> Signed-off-by: Bruce Rogers <brogers@novell.com>
>> Signed-off-by: Olaf Kirch <okir@suse.de>
>> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>> Cc: stable@kernel.org
>
> Looks good to me.
>
> Thanks!
Thanks for the review.
We are hoping to get this into our 2.6.32 based sle11 sp1 maintenance update. Are there any concerns with this patch?
Bruce
prev parent reply other threads:[~2010-06-14 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 0:48 [PATCH] KVM: add schedule check to napi_enable call Bruce Rogers
2010-06-06 9:40 ` Herbert Xu
2010-06-14 20:44 ` Bruce Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C16404102000048000980A8@sinclair.provo.novell.com \
--to=brogers@novell.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox