public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.r.fastabend@intel.com>
To: Fred Isaman <iisaman@netapp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	NFS list <linux-nfs@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: patch "net: deliver skbs on inactive slaves to exact matches" stalls 	nfs mounts
Date: Wed, 16 Jun 2010 15:36:33 -0700	[thread overview]
Message-ID: <4C1951F1.9010004@intel.com> (raw)
In-Reply-To: <AANLkTil5gBFkXgmImU1Mt8uJXKTTNCen8NtzWpBxaYdq@mail.gmail.com>

Fred Isaman wrote:
> I am using vmware fusion 3.1.0 on a macbook pro host with a fedora 12
> guest running a 2.6.35-rc3 based kernel,  Upgrading from rc2 to rc3
> introduced a long delay when the guest attempts an nfs mount (~120
> secs).  Reverting patch 597a264b1a9c7e36d1728f677c66c5c1f7e3b837
> "net: deliver skbs on inactive slaves to exact matches" changes back
> to normal behavior.
> 
> Fred

This should be fixed here,

 From e897082fe7a5b591dc4dd5599ac39081a7c8e482 Mon Sep 17 00:00:00 2001
From: John Fastabend <john.r.fastabend@intel.com>
Date: Sun, 13 Jun 2010 10:36:30 +0000
Subject: [PATCH] net: fix deliver_no_wcard regression on loopback device

deliver_no_wcard is not being set in skb_copy_header.
In the skb_cloned case it is not being cleared and
may cause the skb to be dropped when the loopback device
pushes it back up the stack.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2010-06-16 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16 21:27 patch "net: deliver skbs on inactive slaves to exact matches" stalls nfs mounts Fred Isaman
2010-06-16 22:36 ` John Fastabend [this message]
2010-06-16 23:11   ` Fred Isaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1951F1.9010004@intel.com \
    --to=john.r.fastabend@intel.com \
    --cc=davem@davemloft.net \
    --cc=iisaman@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox