From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH 1/5 v2]wireless:hostap_main.c warning: variable 'iface' set but not used Date: Tue, 22 Jun 2010 11:34:30 -0700 Message-ID: <4C210236.3030401@gmail.com> References: <1277157733-14071-1-git-send-email-justinmattock@gmail.com> <20100622181320.GD2583@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "John W. Linville" Return-path: Received: from mail-pv0-f174.google.com ([74.125.83.174]:53829 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752349Ab0FVSeX (ORCPT ); Tue, 22 Jun 2010 14:34:23 -0400 In-Reply-To: <20100622181320.GD2583@tuxdriver.com> Sender: netdev-owner@vger.kernel.org List-ID: On 06/22/2010 11:13 AM, John W. Linville wrote: > On Mon, Jun 21, 2010 at 03:02:13PM -0700, Justin P. Mattock wrote: >> This is a resend from version one due to trying a different approach >> than the original(probably important to leave netdev_priv() in). >> >> In any case have a look, if there's another approach let me know >> and ill test it out. The below patch fixes a warning im seeing >> when compiling with gcc 4.6.0 >> >> CC [M] drivers/net/wireless/hostap/hostap_main.o >> drivers/net/wireless/hostap/hostap_main.c: In function 'hostap_set_multicast_list_queue': >> drivers/net/wireless/hostap/hostap_main.c:744:27: warning: variable 'iface' set but not used >> Signed-off-by: Justin P. Mattock > > I already applied the other version to wireless-next-2.6. I can't > imagine what you mean to accomplish by leaving in a call to netdev_priv > w/o assigning the result to something. > > John alright.. as for the netdev_priv, I was getting confused on this one. Thanks for taking the time to look at this. Justin P. Mattock