From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: fw@strlen.de, jpirko@redhat.com, netdev@vger.kernel.org,
Balazs Scheidler <bazsi@balabit.hu>,
KOVACS Krisztian <hidden@sch.bme.hu>
Subject: Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed
Date: Thu, 24 Jun 2010 17:29:29 +0200 [thread overview]
Message-ID: <4C2379D9.2080608@trash.net> (raw)
In-Reply-To: <20100623.115558.189705237.davem@davemloft.net>
David Miller wrote:
> From: Florian Westphal <fw@strlen.de>
> Date: Wed, 23 Jun 2010 20:46:11 +0200
>
>
>> tproxy assigns skb->destructor, what prevents module unload while such skbs may
>> still be around?
>>
>
> The only reference to nf_tproxy_core.ko is for the symbol, "nf_tproxy_assign_sock".
> xt_TPROXY.c, which references this symbol, thus creates a symbol dependency on this
> module, so xt_TPROXY.o needs to unload before nf_tproxy_core.ko can unload, and
> xt_TPROXY.o has it's own manner for handling module references properly.
>
I don't see anything waiting for skbs in flight using the tproxy
destructor in either xt_TPROXY or nf_tproxy_core though, so I think
Florian is correct.
next prev parent reply other threads:[~2010-06-24 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 18:35 [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to be removed Jiri Pirko
2010-06-23 18:46 ` Florian Westphal
2010-06-23 18:55 ` David Miller
2010-06-24 15:29 ` Patrick McHardy [this message]
2010-06-25 7:56 ` KOVACS Krisztian
2010-06-29 6:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2379D9.2080608@trash.net \
--to=kaber@trash.net \
--cc=bazsi@balabit.hu \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=hidden@sch.bme.hu \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).