From: Cong Wang <amwang@redhat.com>
To: Jon Mason <jon.mason@exar.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sgruszka@redhat.com" <sgruszka@redhat.com>,
"herbert.xu@redhat.com" <herbert.xu@redhat.com>,
"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
Ramkrishna Vepa <Ramkrishna.Vepa@exar.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [v4 Patch 1/2] s2io: add dynamic LRO disable support
Date: Fri, 25 Jun 2010 17:01:36 +0800 [thread overview]
Message-ID: <4C247070.9030003@redhat.com> (raw)
In-Reply-To: <20100625043343.GB2739@exar.com>
On 06/25/10 12:33, Jon Mason wrote:
> On Tue, Jun 22, 2010 at 01:50:07AM -0700, Amerigo Wang wrote:
>>
>> This patch adds dynamic LRO diable support for s2io net driver.
>>
>> (I don't have s2io card, so only did compiling test. Anyone who wants
>> to test this is more than welcome.)
>
> Unfortunately the patch did not quite work, mostly due to NETIF_F_LRO
> needing to be added at probe time to the device features. I was able
> to modify the patch to get it working, and will respond seperately
> with the working patch.
>
Thanks very much, Jon!
I am very pleased to see this patch gets tested. :)
next prev parent reply other threads:[~2010-06-25 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 8:50 [v4 Patch 1/2] s2io: add dynamic LRO disable support Amerigo Wang
2010-06-22 8:50 ` [v4 Patch 2/2] mlx4: " Amerigo Wang
2010-06-29 6:04 ` David Miller
2010-06-22 11:44 ` [v4 Patch 1/2] s2io: " Ben Hutchings
2010-06-22 12:31 ` Stanislaw Gruszka
2010-06-25 8:59 ` Cong Wang
2010-06-25 4:33 ` Jon Mason
2010-06-25 9:01 ` Cong Wang [this message]
2010-06-25 4:45 ` [PATCH] " Jon Mason
2010-06-25 9:09 ` Cong Wang
2010-06-29 6:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C247070.9030003@redhat.com \
--to=amwang@redhat.com \
--cc=Ramkrishna.Vepa@exar.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=herbert.xu@redhat.com \
--cc=jon.mason@exar.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).