From: Stefan Assmann <sassmann@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: e1000-devel@lists.sourceforge.net,
netdev <netdev@vger.kernel.org>,
kay.sievers@vrfy.org, gregory.v.rose@intel.com,
jeffrey.t.kirsher@intel.com, Andy Gospodarek <gospo@redhat.com>,
harald@redhat.com
Subject: Re: [PATCH] igbvf: avoid name clash between PF and VF
Date: Wed, 30 Jun 2010 12:57:01 +0200 [thread overview]
Message-ID: <4C2B22FD.4050705@redhat.com> (raw)
In-Reply-To: <1277894679.28819.60.camel@localhost>
On 30.06.2010 12:44, Ben Hutchings wrote:
> On Wed, 2010-06-30 at 10:53 +0200, Stefan Assmann wrote:
>> From: Stefan Assmann <sassmann@redhat.com>
>>
>> It looks like the VFs get initialized before all the PFs are. Therefore
>> the udev mapping MAC <-> ethX (for PFs) gets screwed because the VFs
>> may grab the ethX interface names (reserved by udev) for the PFs.
>>
>> Example:
>> igb max_vfs=0
>> eth0 Link encap:Ethernet HWaddr 00:13:20:F7:A5:9E
>> eth1 Link encap:Ethernet HWaddr 00:13:20:F7:A5:9F
>> eth2 Link encap:Ethernet HWaddr 00:13:20:F7:A5:A0
>> eth3 Link encap:Ethernet HWaddr 00:13:20:F7:A5:A1
>> igb max_vfs=1
>> eth0 Link encap:Ethernet HWaddr 00:13:20:F7:A5:9E
>> eth1 Link encap:Ethernet HWaddr 0A:CF:41:69:F7:A9
>> eth2 Link encap:Ethernet HWaddr 3A:FE:20:4C:2A:3B
>> eth3 Link encap:Ethernet HWaddr C6:C3:B1:56:C9:A4
>> eth3_rename Link encap:Ethernet HWaddr 00:13:20:F7:A5:9F
>> eth4 Link encap:Ethernet HWaddr 6E:8A:8A:A3:5F:69
>> eth4_rename Link encap:Ethernet HWaddr 00:13:20:F7:A5:A0
>> eth5_rename Link encap:Ethernet HWaddr 00:13:20:F7:A5:A1
>>
>> In the example above VF 0A:CF:41:69:F7:A9 grabs eth1 but udev
>> has a rule that says eth1 should be assigned PF 00:13:20:F7:A5:9F
>> (eth3_rename) and waits for the VF to disappear to rename eth3_rename
>> to eth1. Unfortunately eth1 is not going to disappear.
>> This is not a udev bug since udev doesn't create persistent rules for
>> VFs as their MAC address changes every reboot.
> [...]
>
> I think it is a bug in the udev rules: udev should rename the VFs even
> though their names won't be persistent.
In that case let's Cc udev people.
Stefan
--
Stefan Assmann | Red Hat GmbH
Software Engineer | Otto-Hahn-Strasse 20, 85609 Dornach
| HR: Amtsgericht Muenchen HRB 153243
| GF: Brendan Lane, Charlie Peters,
sassmann at redhat.com | Michael Cunningham, Charles Cachera
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2010-06-30 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 8:53 [PATCH] igbvf: avoid name clash between PF and VF Stefan Assmann
2010-06-30 10:44 ` Ben Hutchings
2010-06-30 10:57 ` Stefan Assmann [this message]
2010-06-30 11:11 ` Kay Sievers
2010-06-30 13:07 ` Harald Hoyer
2010-06-30 16:59 ` Casey Leedom
2010-07-01 6:37 ` Stefan Assmann
2010-07-01 17:12 ` Casey Leedom
2010-07-02 6:37 ` Stefan Assmann
2010-07-08 13:41 ` Arnd Bergmann
2010-07-09 9:31 ` Stefan Assmann
2010-07-09 15:33 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2B22FD.4050705@redhat.com \
--to=sassmann@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=harald@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kay.sievers@vrfy.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).