From: Patrick McHardy <kaber@trash.net>
To: Jiri Pirko <jpirko@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, ole@ans.pl
Subject: Re: [PATCH net-next-2.6] netfilter: remove deprecated config option NF_CT_ACCT
Date: Wed, 30 Jun 2010 14:53:17 +0200 [thread overview]
Message-ID: <4C2B3E3D.7030804@trash.net> (raw)
In-Reply-To: <20100630124954.GA2582@psychotron.brq.redhat.com>
Jiri Pirko wrote:
> Wed, Jun 30, 2010 at 02:10:31PM CEST, kaber@trash.net wrote:
>
>> Jiri Pirko wrote:
>>
>>> This patch removes deprecated config option NF_CT_ACCT. The default value is set
>>> to 0 and warning message is put into connbytes_mt_init (connbytes selected
>>> NF_CT_ACCT to enable it by default).
>>>
>> Thanks, I already have a patch queued in nf-next for this.
>>
>>
>
> Oh, I see that: d70a011dbbaa6335a19deb63ec3eb613f48faafd
>
a8756201ba4189bca3ee1a6ec4e290f467ee09ab also belongs to the removal.
>
> Apart your patch doesn't remove option from defconfigs (not sure if that's
> necessary or not), your patch also do not print warning in connbytes_mt_init.
> That would make connbytes silently non-functional. Therefore I think my patch is
> better (more complete).
The patch I have queued is automatically enabling accounting when
the connbytes match is used and is printing a warning.
next prev parent reply other threads:[~2010-06-30 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 15:45 [PATCH net-next-2.6] netfilter: remove deprecated config option NF_CT_ACCT Jiri Pirko
2010-06-30 12:10 ` Patrick McHardy
2010-06-30 12:49 ` Jiri Pirko
2010-06-30 12:53 ` Patrick McHardy [this message]
2010-06-30 13:11 ` Jiri Pirko
2010-06-30 13:42 ` Patrick McHardy
2010-06-30 14:15 ` Jiri Pirko
2010-06-30 17:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2B3E3D.7030804@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ole@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).