From: Denis Kirjanov <dkirjanov@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: dm@chelsio.com, dkirjanov@hera.kernel.org, netdev@vger.kernel.org
Subject: Re: [RESEND][PATCH] cxgb4: Use kfree_skb for skb pointers
Date: Sat, 03 Jul 2010 10:56:06 +0400 [thread overview]
Message-ID: <4C2EDF06.1000706@kernel.org> (raw)
In-Reply-To: <20100702.234342.71126498.davem@davemloft.net>
On 07/03/2010 10:43 AM, David Miller wrote:
> From: "Dimitrios Michailidis"<dm@chelsio.com>
> Date: Fri, 2 Jul 2010 22:51:17 -0700
>
>>
>>> From: Denis Kirjanov<dkirjanov@hera.kernel.org>
>>> Date: Thu, 1 Jul 2010 09:45:52 +0000
>>>
>>>> Use kfree_skb for skb pointers
>>>>
>>>> Acked-by: Dimitris Michailidis<dm@chelsio.com>
>>>> Signed-off-by: Denis Kirjanov<dkirjanov@kernel.org>
>>>
>>> The code is completely different in this part of the driver now, this
>>> patch does not apply.
>>>
>>> In fact there is no reference to the string "kfree" at all in the
>>> l2t.c file of the cxgb4 driver :)
>>
>> This patch is for net-next and it should apply there, I see the wrong
>> kfree (there's only one kfree). Denis didn't mention net-next, maybe
>> you tried to apply it to net-2.6?
>
> Yes, I did.
>
> That's why people should always indicate what tree a patch is for
> in the subject line or similar.
>
Yes, I'll be more accurate next time.
Thanks.
prev parent reply other threads:[~2010-07-03 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 9:45 [RESEND][PATCH] cxgb4: Use kfree_skb for skb pointers Denis Kirjanov
2010-07-03 5:28 ` David Miller
2010-07-03 5:51 ` Dimitrios Michailidis
2010-07-03 6:43 ` David Miller
2010-07-03 6:56 ` Denis Kirjanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2EDF06.1000706@kernel.org \
--to=dkirjanov@kernel.org \
--cc=davem@davemloft.net \
--cc=dkirjanov@hera.kernel.org \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).