From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH] CAN: Add Flexcan CAN controller driver Date: Thu, 15 Jul 2010 11:37:57 +0200 Message-ID: <4C3ED6F5.7040606@grandegger.com> References: <1279144811-12251-1-git-send-email-mkl@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marc Kleine-Budde Return-path: In-Reply-To: <1279144811-12251-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org Hi Marc, On 07/15/2010 12:00 AM, Marc Kleine-Budde wrote: > From: Sascha Hauer > > This core is found on some Freescale SoCs and also some Coldfire > SoCs. Support for Coldfire is missing though at the moment as > they have an older revision of the core which does not have RX FIFO > support. > > Signed-off-by: Sascha Hauer > Signed-off-by: Marc Kleine-Budde > --- > > Changes to prev version: > * The is now GPLv2 (only) as no one complained. > > The patch applies to current net-next-2.6/master. > If there aren't any objections please consider applying this patch. > Wolfgang, can I an Acked-by? I already had a look to the previous version and I realized that accessing reg_esr is racy. I will dig out my notes and come up with a full review later today or tomorrow. Thanks, Wolfgang.