From: Randy Dunlap <randy.dunlap@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: [PATCH -next] net: NET_DSA depends on NET_ETHERNET
Date: Tue, 20 Jul 2010 16:03:32 -0700 [thread overview]
Message-ID: <4C462B44.5010107@oracle.com> (raw)
In-Reply-To: <20100710.190954.245403400.davem@davemloft.net>
From: Randy Dunlap <randy.dunlap@oracle.com>
NET_DSA code selects and uses PHYLIB code, but PHYLIB depends on
NET_ETHERNET. However, "select" does not follow kconfig dependencies,
so explicitly list that requirement here instead.
Fixes this kconfig warning:
warning: (NET_DSA && NET && EXPERIMENTAL && !S390 ...) selects PHYLIB which has unmet direct dependencies (!S390 && NET_ETHERNET)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Lennert Buytenhek <buytenh@wantstofly.org>
---
net/dsa/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Is there some reason that NET_DSA is bool instead of tristate?
I.e., net/dsa/ code cannot be built as loadable modules?
--- linux-next-20100713.orig/net/dsa/Kconfig
+++ linux-next-20100713/net/dsa/Kconfig
@@ -1,7 +1,7 @@
menuconfig NET_DSA
bool "Distributed Switch Architecture support"
default n
- depends on EXPERIMENTAL && !S390
+ depends on EXPERIMENTAL && !S390 && NET_ETHERNET
select PHYLIB
---help---
This allows you to use hardware switch chips that use
next prev parent reply other threads:[~2010-07-20 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100706190519.93d8b785.sfr@canb.auug.org.au>
2010-07-06 17:34 ` linux-next: Tree for July 6 (NET_DSA + PHYLIB kconfig) Randy Dunlap
2010-07-11 2:09 ` David Miller
2010-07-20 23:03 ` Randy Dunlap [this message]
2010-07-21 0:45 ` [PATCH -next] net: NET_DSA depends on NET_ETHERNET David Miller
2010-07-21 5:41 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C462B44.5010107@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).