From: Ben Greear <greearb@candelatech.com>
To: Brian Haley <brian.haley@hp.com>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute2] iproute2: Fix 'addr flush secondary' logic.
Date: Wed, 11 Aug 2010 13:53:29 -0700 [thread overview]
Message-ID: <4C630DC9.9030608@candelatech.com> (raw)
In-Reply-To: <4C630B0A.9010304@hp.com>
On 08/11/2010 01:41 PM, Brian Haley wrote:
> On 08/11/2010 01:19 PM, Ben Greear wrote:
>> @@ -648,7 +648,7 @@ int print_addrinfo_secondary(const struct sockaddr_nl *who, struct nlmsghdr *n,
>> {
>> struct ifaddrmsg *ifa = NLMSG_DATA(n);
>>
>> - if (ifa->ifa_flags& IFA_F_SECONDARY)
>> + if (!ifa->ifa_flags& IFA_F_SECONDARY)
>> return 0;
>
> Shouldn't this be:
>
> if (!(ifa->ifa_flags& IFA_F_SECONDARY))
Yes, that looks like a bug. Let me re-test to make sure
it wasn't hiding other bugs and will re-submit.
Thanks,
Ben
>
> -Brian
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-08-11 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 17:19 [iproute2] iproute2: Fix 'addr flush secondary' logic Ben Greear
2010-08-11 20:41 ` Brian Haley
2010-08-11 20:53 ` Ben Greear [this message]
2010-08-11 22:48 ` Ben Greear
2010-08-12 19:00 ` Brian Haley
2010-08-12 19:10 ` Ben Greear
2010-08-13 19:49 ` Ben Greear
2010-08-16 15:58 ` Brian Haley
2010-08-16 17:01 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C630DC9.9030608@candelatech.com \
--to=greearb@candelatech.com \
--cc=brian.haley@hp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).