netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC Patch] netxen: remove firmware exports
@ 2010-08-18  9:54 Amerigo Wang
  2010-08-18 11:04 ` Amit Salecha
  2010-08-19  9:12 ` Amit Salecha
  0 siblings, 2 replies; 9+ messages in thread
From: Amerigo Wang @ 2010-08-18  9:54 UTC (permalink / raw)
  To: linux-kernel
  Cc: Dhananjay Phadke, Amit Kumar Salecha, Narender Kumar, netdev,
	David S. Miller, Amerigo Wang


netxen_nic driver can store firmwares on flash, and get them porperly and
dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
still exports these firmwares via modinfo, this makes our script which parses
modinfo output fail.

Probably netxen_nic has other way to export these firmwares, but not like other
modules in a stardand way. I think we can just remove these exports, but
I am not sure.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Cc: Narender Kumar <narender.kumar@qlogic.com>

---
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index fd86e18..e8443af 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -41,10 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";
 static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* RE: [RFC Patch] netxen: remove firmware exports
  2010-08-18  9:54 [RFC Patch] netxen: remove firmware exports Amerigo Wang
@ 2010-08-18 11:04 ` Amit Salecha
  2010-08-18 13:19   ` Cong Wang
  2010-08-19  9:12 ` Amit Salecha
  1 sibling, 1 reply; 9+ messages in thread
From: Amit Salecha @ 2010-08-18 11:04 UTC (permalink / raw)
  To: Amerigo Wang, linux-kernel@vger.kernel.org
  Cc: Dhananjay Phadke, Narender Kumar, netdev@vger.kernel.org,
	David S. Miller, Ameen Rahman

If problem is firmware files are not present in /lib/firmware.
Then we can work with David Woodhouse and make these firmware available in /lib/firmware.

-----Original Message-----
From: Amerigo Wang [mailto:amwang@redhat.com] 
Sent: Wednesday, August 18, 2010 3:25 PM
To: linux-kernel@vger.kernel.org
Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; netdev@vger.kernel.org; David S. Miller; Amerigo Wang
Subject: [RFC Patch] netxen: remove firmware exports


netxen_nic driver can store firmwares on flash, and get them porperly and
dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
still exports these firmwares via modinfo, this makes our script which parses
modinfo output fail.

Probably netxen_nic has other way to export these firmwares, but not like other
modules in a stardand way. I think we can just remove these exports, but
I am not sure.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Cc: Narender Kumar <narender.kumar@qlogic.com>

---
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index fd86e18..e8443af 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -41,10 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";
 static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [RFC Patch] netxen: remove firmware exports
  2010-08-18 11:04 ` Amit Salecha
@ 2010-08-18 13:19   ` Cong Wang
  2010-08-18 13:19     ` Amit Salecha
  0 siblings, 1 reply; 9+ messages in thread
From: Cong Wang @ 2010-08-18 13:19 UTC (permalink / raw)
  To: Amit Salecha
  Cc: linux-kernel@vger.kernel.org, Dhananjay Phadke, Narender Kumar,
	netdev@vger.kernel.org, David S. Miller, Ameen Rahman

On 08/18/10 19:04, Amit Salecha wrote:
> If problem is firmware files are not present in /lib/firmware.
> Then we can work with David Woodhouse and make these firmware available in /lib/firmware.
>

Oh, I thought we did this intentionally.
That would be nice then, please go ahead.

Thanks!

-- 
The opposite of love is not hate, it's indifference.
  - Elie Wiesel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [RFC Patch] netxen: remove firmware exports
  2010-08-18 13:19   ` Cong Wang
@ 2010-08-18 13:19     ` Amit Salecha
  2010-08-18 13:40       ` Cong Wang
  0 siblings, 1 reply; 9+ messages in thread
From: Amit Salecha @ 2010-08-18 13:19 UTC (permalink / raw)
  To: Cong Wang
  Cc: linux-kernel@vger.kernel.org, Dhananjay Phadke, Narender Kumar,
	netdev@vger.kernel.org, David S. Miller, Ameen Rahman

> Then we can work with David Woodhouse and make these firmware available in /lib/firmware
>
Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already submitted and its present in linux-firmware.git.

I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and NX_P3_MN_ROMIMAGE_NAME.
Whether this will be submitted ?

-----Original Message-----
From: Cong Wang [mailto:amwang@redhat.com] 
Sent: Wednesday, August 18, 2010 6:49 PM
To: Amit Salecha
Cc: linux-kernel@vger.kernel.org; Dhananjay Phadke; Narender Kumar; netdev@vger.kernel.org; David S. Miller; Ameen Rahman
Subject: Re: [RFC Patch] netxen: remove firmware exports

On 08/18/10 19:04, Amit Salecha wrote:
> If problem is firmware files are not present in /lib/firmware.
> Then we can work with David Woodhouse and make these firmware available in /lib/firmware.
>

Oh, I thought we did this intentionally.
That would be nice then, please go ahead.

Thanks!

-- 
The opposite of love is not hate, it's indifference.
  - Elie Wiesel


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC Patch] netxen: remove firmware exports
  2010-08-18 13:19     ` Amit Salecha
@ 2010-08-18 13:40       ` Cong Wang
  0 siblings, 0 replies; 9+ messages in thread
From: Cong Wang @ 2010-08-18 13:40 UTC (permalink / raw)
  To: Amit Salecha
  Cc: linux-kernel@vger.kernel.org, Dhananjay Phadke, Narender Kumar,
	netdev@vger.kernel.org, David S. Miller, Ameen Rahman

On 08/18/10 21:19, Amit Salecha wrote:
>> Then we can work with David Woodhouse and make these firmware available in /lib/firmware
>>
> Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already submitted and its present in linux-firmware.git.
>

Good.

> I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and NX_P3_MN_ROMIMAGE_NAME.
> Whether this will be submitted ?
>

Ok, thanks a lot!


-- 
The opposite of love is not hate, it's indifference.
  - Elie Wiesel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [RFC Patch] netxen: remove firmware exports
  2010-08-18  9:54 [RFC Patch] netxen: remove firmware exports Amerigo Wang
  2010-08-18 11:04 ` Amit Salecha
@ 2010-08-19  9:12 ` Amit Salecha
  2010-08-20  8:52   ` Cong Wang
  2010-08-20  9:04   ` Cong Wang
  1 sibling, 2 replies; 9+ messages in thread
From: Amit Salecha @ 2010-08-19  9:12 UTC (permalink / raw)
  To: Amerigo Wang, linux-kernel@vger.kernel.org, David S. Miller
  Cc: Dhananjay Phadke, Narender Kumar, netdev@vger.kernel.org

> netxen_nic driver can store firmwares on flash, and get them porperly and
> dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
> still exports these firmwares via modinfo, this makes our script which parses
> modinfo output fail.

NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.

> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
> -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
> -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);

It's not compulsory to submit firmware files which are exported (MODULE_FIRMWARE).
I am leaving this upto David to decide about this patch.

-Amit

-----Original Message-----
From: Amerigo Wang [mailto:amwang@redhat.com] 
Sent: Wednesday, August 18, 2010 3:25 PM
To: linux-kernel@vger.kernel.org
Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; netdev@vger.kernel.org; David S. Miller; Amerigo Wang
Subject: [RFC Patch] netxen: remove firmware exports


netxen_nic driver can store firmwares on flash, and get them porperly and
dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
still exports these firmwares via modinfo, this makes our script which parses
modinfo output fail.

Probably netxen_nic has other way to export these firmwares, but not like other
modules in a stardand way. I think we can just remove these exports, but
I am not sure.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Cc: Narender Kumar <narender.kumar@qlogic.com>

---
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index fd86e18..e8443af 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -41,10 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";
 static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [RFC Patch] netxen: remove firmware exports
  2010-08-19  9:12 ` Amit Salecha
@ 2010-08-20  8:52   ` Cong Wang
  2010-08-20  8:53     ` Amit Salecha
  2010-08-20  9:04   ` Cong Wang
  1 sibling, 1 reply; 9+ messages in thread
From: Cong Wang @ 2010-08-20  8:52 UTC (permalink / raw)
  To: Amit Salecha
  Cc: linux-kernel@vger.kernel.org, David S. Miller, Dhananjay Phadke,
	Narender Kumar, netdev@vger.kernel.org

On 08/19/10 17:12, Amit Salecha wrote:
>> netxen_nic driver can store firmwares on flash, and get them porperly and
>> dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
>> still exports these firmwares via modinfo, this makes our script which parses
>> modinfo output fail.
>
> NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.
>
>> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
>> -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
>> -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
>
> It's not compulsory to submit firmware files which are exported (MODULE_FIRMWARE).
> I am leaving this upto David to decide about this patch.
>

Okay. David, do you want me to submit an updated patch?

Thanks!

-- 
The opposite of love is not hate, it's indifference.
  - Elie Wiesel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [RFC Patch] netxen: remove firmware exports
  2010-08-20  8:52   ` Cong Wang
@ 2010-08-20  8:53     ` Amit Salecha
  0 siblings, 0 replies; 9+ messages in thread
From: Amit Salecha @ 2010-08-20  8:53 UTC (permalink / raw)
  To: Cong Wang
  Cc: linux-kernel@vger.kernel.org, David S. Miller, Dhananjay Phadke,
	Narender Kumar, netdev@vger.kernel.org

> Okay. David, do you want me to submit an updated patch?

You have to submit updated patch.

-Amit

> -----Original Message-----
> From: Cong Wang [mailto:amwang@redhat.com]
> Sent: Friday, August 20, 2010 2:22 PM
> To: Amit Salecha
> Cc: linux-kernel@vger.kernel.org; David S. Miller; Dhananjay Phadke;
> Narender Kumar; netdev@vger.kernel.org
> Subject: Re: [RFC Patch] netxen: remove firmware exports
> 
> On 08/19/10 17:12, Amit Salecha wrote:
> >> netxen_nic driver can store firmwares on flash, and get them
> porperly and
> >> dynamically, so the firmwares may not appear in /lib/firmware/.
> However, netxen_nic
> >> still exports these firmwares via modinfo, this makes our script
> which parses
> >> modinfo output fail.
> >
> > NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we
> won't submit any other fw files.
> >
> >> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
> >> -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
> >> -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
> >
> > It's not compulsory to submit firmware files which are exported
> (MODULE_FIRMWARE).
> > I am leaving this upto David to decide about this patch.
> >
> 
> Okay. David, do you want me to submit an updated patch?
> 
> Thanks!
> 
> --
> The opposite of love is not hate, it's indifference.
>   - Elie Wiesel


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC Patch] netxen: remove firmware exports
  2010-08-19  9:12 ` Amit Salecha
  2010-08-20  8:52   ` Cong Wang
@ 2010-08-20  9:04   ` Cong Wang
  1 sibling, 0 replies; 9+ messages in thread
From: Cong Wang @ 2010-08-20  9:04 UTC (permalink / raw)
  To: Amit Salecha
  Cc: linux-kernel@vger.kernel.org, David S. Miller, Dhananjay Phadke,
	Narender Kumar, netdev@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

On 08/19/10 17:12, Amit Salecha wrote:
> NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.

Based on above, remove the rest firmware exports.

Thanks!

-- 
Signed-off-by: WANG Cong <amwang@redhat.com>

[-- Attachment #2: drivers-net-netxen-remove-firmwares.diff --]
[-- Type: text/x-patch, Size: 586 bytes --]

diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index fd86e18..2fedc3b 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -41,9 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
 MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2010-08-20  9:04 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18  9:54 [RFC Patch] netxen: remove firmware exports Amerigo Wang
2010-08-18 11:04 ` Amit Salecha
2010-08-18 13:19   ` Cong Wang
2010-08-18 13:19     ` Amit Salecha
2010-08-18 13:40       ` Cong Wang
2010-08-19  9:12 ` Amit Salecha
2010-08-20  8:52   ` Cong Wang
2010-08-20  8:53     ` Amit Salecha
2010-08-20  9:04   ` Cong Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).