netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC Patch] netxen: remove firmware exports
@ 2010-08-18  9:54 Amerigo Wang
  2010-08-18 11:04 ` Amit Salecha
  2010-08-19  9:12 ` Amit Salecha
  0 siblings, 2 replies; 9+ messages in thread
From: Amerigo Wang @ 2010-08-18  9:54 UTC (permalink / raw)
  To: linux-kernel
  Cc: Dhananjay Phadke, Amit Kumar Salecha, Narender Kumar, netdev,
	David S. Miller, Amerigo Wang


netxen_nic driver can store firmwares on flash, and get them porperly and
dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
still exports these firmwares via modinfo, this makes our script which parses
modinfo output fail.

Probably netxen_nic has other way to export these firmwares, but not like other
modules in a stardand way. I think we can just remove these exports, but
I am not sure.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Cc: Narender Kumar <narender.kumar@qlogic.com>

---
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index fd86e18..e8443af 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -41,10 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";
 static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2010-08-20  9:04 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18  9:54 [RFC Patch] netxen: remove firmware exports Amerigo Wang
2010-08-18 11:04 ` Amit Salecha
2010-08-18 13:19   ` Cong Wang
2010-08-18 13:19     ` Amit Salecha
2010-08-18 13:40       ` Cong Wang
2010-08-19  9:12 ` Amit Salecha
2010-08-20  8:52   ` Cong Wang
2010-08-20  8:53     ` Amit Salecha
2010-08-20  9:04   ` Cong Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).