From: Cong Wang <amwang@redhat.com>
To: Amit Salecha <amit.salecha@qlogic.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Dhananjay Phadke <dhananjay.phadke@qlogic.com>,
Narender Kumar <narender.kumar@qlogic.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC Patch] netxen: remove firmware exports
Date: Fri, 20 Aug 2010 16:52:14 +0800 [thread overview]
Message-ID: <4C6E423E.5080804@redhat.com> (raw)
In-Reply-To: <99737F4847ED0A48AECC9F4A1974A4B80F86E69208@MNEXMB2.qlogic.org>
On 08/19/10 17:12, Amit Salecha wrote:
>> netxen_nic driver can store firmwares on flash, and get them porperly and
>> dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic
>> still exports these firmwares via modinfo, this makes our script which parses
>> modinfo output fail.
>
> NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.
>
>> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
>> -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
>> -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
>
> It's not compulsory to submit firmware files which are exported (MODULE_FIRMWARE).
> I am leaving this upto David to decide about this patch.
>
Okay. David, do you want me to submit an updated patch?
Thanks!
--
The opposite of love is not hate, it's indifference.
- Elie Wiesel
next prev parent reply other threads:[~2010-08-20 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 9:54 [RFC Patch] netxen: remove firmware exports Amerigo Wang
2010-08-18 11:04 ` Amit Salecha
2010-08-18 13:19 ` Cong Wang
2010-08-18 13:19 ` Amit Salecha
2010-08-18 13:40 ` Cong Wang
2010-08-19 9:12 ` Amit Salecha
2010-08-20 8:52 ` Cong Wang [this message]
2010-08-20 8:53 ` Amit Salecha
2010-08-20 9:04 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6E423E.5080804@redhat.com \
--to=amwang@redhat.com \
--cc=amit.salecha@qlogic.com \
--cc=davem@davemloft.net \
--cc=dhananjay.phadke@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narender.kumar@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).