Re: [PATCH] netxen: fix poll implementation

Re: [PATCH] netxen: fix poll implementation

[David Miller]

Both of your patches have been severely corrupted by your email
client.

For example, tab characters have been changed into spaces.

This makes your patches unusable.

Please read Documentation/email-clients.txt to learn how to correct
this, try sending a patch to yourself and verify that it arrives
to you correctly and can be applied properly, then resubmit your
patches.

Thanks.

[PATCH] netxen: fix poll implementation

[Yinglin Luan]

Function netxen_intr has pointer to nx_host_sds_ring
as second parameter not pointer to netxen_adapter.

Signed-off-by: Yinglin Luan <synmyth@gmail.com>
---
 drivers/net/netxen/netxen_nic_main.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index fd86e18..4147be5 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -2133,9 +2133,16 @@ static int netxen_nic_poll(struct napi_struct *napi, int budget)
 #ifdef CONFIG_NET_POLL_CONTROLLER
 static void netxen_nic_poll_controller(struct net_device *netdev)
 {
+	int ring;
+	struct nx_host_sds_ring *sds_ring;
 	struct netxen_adapter *adapter = netdev_priv(netdev);
+	struct netxen_recv_context *recv_ctx = &adapter->recv_ctx;
+
 	disable_irq(adapter->irq);
-	netxen_intr(adapter->irq, adapter);
+	for (ring = 0; ring < adapter->max_sds_rings; ring++) {
+		sds_ring = &recv_ctx->sds_rings[ring];
+		netxen_intr(adapter->irq, sds_ring);
+	}
 	enable_irq(adapter->irq);
 }
 #endif
-- 
1.7.0.4

Re: [PATCH] netxen: fix poll implementation

[Yinglin Luan]

> 
> Both of your patches have been severely corrupted by your email
> client.
> 
> For example, tab characters have been changed into spaces.
> 
> This makes your patches unusable.
> 
> Please read Documentation/email-clients.txt to learn how to correct
> this, try sending a patch to yourself and verify that it arrives
> to you correctly and can be applied properly, then resubmit your
> patches.
> 
> Thanks.
Sorry, it's my first time to submit patches to kernel community. I
use Gmail web client, and it automatically converts tabs to spaces.
I change my e-mail client to Thunderbird and configure it as
Documentation/email-clients.txt says. It shouled be applied properly, 
I have resubmit it just now, please check it again. Thanks a lot!

Re: [PATCH] netxen: fix poll implementation

[David Miller]

From: Yinglin Luan <synmyth@gmail.com>
Date: Mon, 23 Aug 2010 15:56:19 +0800

> Function netxen_intr has pointer to nx_host_sds_ring
> as second parameter not pointer to netxen_adapter.
> 
> Signed-off-by: Yinglin Luan <synmyth@gmail.com>

Applied.