* [PATCH] [AX25] missplaced sock_put(sk)
@ 2010-08-26 19:34 Bernard F6BVP
2010-08-26 21:09 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Bernard F6BVP @ 2010-08-26 19:34 UTC (permalink / raw)
To: ralf; +Cc: davem, linux-hams, netdev, bpidoux
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
[PATCH] [AX25] missplaced sock_put(sk)
This patch moves a missplaced sock_put(sk) after
bh_unlock_sock(sk)
like in other parts of AX25 driver.
Bernard Pidoux
[-- Attachment #2: ax25_ds_timer.patch --]
[-- Type: text/x-patch, Size: 346 bytes --]
--- linux/net/ax25/ax25_ds_timer.c 2010-08-13 22:44:56.000000000 +0200
+++ linux/net/ax25/ax25_ds_timer.c 2010-08-26 19:55:13.000000000 +0200
@@ -112,8 +112,8 @@
if (sk) {
sock_hold(sk);
ax25_destroy_socket(ax25);
- sock_put(sk);
bh_unlock_sock(sk);
+ sock_put(sk);
} else
ax25_destroy_socket(ax25);
return;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [AX25] missplaced sock_put(sk)
2010-08-26 19:34 Bernard F6BVP
@ 2010-08-26 21:09 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-26 21:09 UTC (permalink / raw)
To: f6bvp; +Cc: ralf, linux-hams, netdev, bpidoux
From: Bernard F6BVP <f6bvp@free.fr>
Date: Thu, 26 Aug 2010 21:34:32 +0200
> [PATCH] [AX25] missplaced sock_put(sk)
>
> This patch moves a missplaced sock_put(sk) after
> bh_unlock_sock(sk)
> like in other parts of AX25 driver.
>
> Bernard Pidoux
Please resubmit this with a proper "Signed-off-by: " tag
as-per Documentation/SubmittingPatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [AX25] missplaced sock_put(sk)
@ 2010-08-26 21:40 Bernard F6BVP
2010-08-26 22:16 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Bernard F6BVP @ 2010-08-26 21:40 UTC (permalink / raw)
To: ralf; +Cc: davem, linux-hams, netdev, bpidoux
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
[PATCH] [AX25] missplaced sock_put(sk)
This patch moves a missplaced sock_put(sk) after
bh_unlock_sock(sk)
like in other parts of AX25 driver.
Signed-off-by: Bernard Pidoux <f6bvp@free.fr>
[-- Attachment #2: ax25_ds_timer.patch --]
[-- Type: text/x-patch, Size: 338 bytes --]
--- a/net/ax25/ax25_ds_timer.c 2010-08-26 23:36:45.000000000 +0200
+++ b/net/ax25/ax25_ds_timer.c 2010-08-26 19:55:13.000000000 +0200
@@ -112,8 +112,8 @@
if (sk) {
sock_hold(sk);
ax25_destroy_socket(ax25);
- sock_put(sk);
bh_unlock_sock(sk);
+ sock_put(sk);
} else
ax25_destroy_socket(ax25);
return;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [AX25] missplaced sock_put(sk)
2010-08-26 21:40 [PATCH] [AX25] missplaced sock_put(sk) Bernard F6BVP
@ 2010-08-26 22:16 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-26 22:16 UTC (permalink / raw)
To: f6bvp; +Cc: ralf, linux-hams, netdev, bpidoux
From: Bernard F6BVP <f6bvp@free.fr>
Date: Thu, 26 Aug 2010 23:40:00 +0200
> [PATCH] [AX25] missplaced sock_put(sk)
>
> This patch moves a missplaced sock_put(sk) after
> bh_unlock_sock(sk)
> like in other parts of AX25 driver.
>
> Signed-off-by: Bernard Pidoux <f6bvp@free.fr>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-26 22:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-26 21:40 [PATCH] [AX25] missplaced sock_put(sk) Bernard F6BVP
2010-08-26 22:16 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-08-26 19:34 Bernard F6BVP
2010-08-26 21:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).