From: Tejun Heo <tj@kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: vhost_dev_cleanup() crash: BUG: unable to handle kernel NULL pointer dereference
Date: Tue, 31 Aug 2010 14:20:54 +0200 [thread overview]
Message-ID: <4C7CF3A6.5060200@kernel.org> (raw)
In-Reply-To: <1283256357.2550.61.camel@edumazet-laptop>
On 08/31/2010 02:05 PM, Eric Dumazet wrote:
> Just in case, I resubmit the patch, clearing dev->worker, because I am
> not sure if vhost_dev_cleanup() can be run several times on same struct
> vhost_dev. Patch is needed even if you add this check in kthread_stop()
>
> [PATCH v2] vhost: stop worker only if created
>
> Its currently illegal to call kthread_stop(NULL)
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2010-08-31 12:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 7:57 vhost_dev_cleanup() crash: BUG: unable to handle kernel NULL pointer dereference Ingo Molnar
2010-08-31 10:50 ` Eric Dumazet
2010-08-31 11:14 ` Ingo Molnar
2010-08-31 12:05 ` Eric Dumazet
2010-08-31 12:20 ` Tejun Heo [this message]
2010-09-01 21:25 ` David Miller
2010-09-01 21:42 ` Michael S. Tsirkin
2010-09-02 1:27 ` David Miller
2010-08-31 19:19 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7CF3A6.5060200@kernel.org \
--to=tj@kernel.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).