* bna: potential null dereference @ 2010-09-04 12:59 Jiri Slaby 2010-09-12 19:02 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: Jiri Slaby @ 2010-09-04 12:59 UTC (permalink / raw) To: ddutt; +Cc: rmody, David S. Miller, ML netdev, LKML Hi, stanse found a potential null dereference: bnad_cb_tx_cleanup -> struct bnad_unmap_q *unmap_q = tcb->unmap_q; -> -- tcb cannot be null now -- -> if (!tcb || (!tcb->unmap_q)) The thing is I have no idea whether the second parameter of cleanup may be null (move assignment after the check) or not (remove the check) Could you fix that? thanks, -- js ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bna: potential null dereference 2010-09-04 12:59 bna: potential null dereference Jiri Slaby @ 2010-09-12 19:02 ` David Miller [not found] ` <AANLkTi=cZyLYJac8b8MsyAA4HitCvpD3NaH7nifzHDLw@mail.gmail.com> 0 siblings, 1 reply; 4+ messages in thread From: David Miller @ 2010-09-12 19:02 UTC (permalink / raw) To: jirislaby; +Cc: ddutt, rmody, netdev, linux-kernel From: Jiri Slaby <jirislaby@gmail.com> Date: Sat, 04 Sep 2010 14:59:54 +0200 > stanse found a potential null dereference: > bnad_cb_tx_cleanup > -> struct bnad_unmap_q *unmap_q = tcb->unmap_q; > -> -- tcb cannot be null now -- > -> if (!tcb || (!tcb->unmap_q)) > > The thing is I have no idea whether the second parameter of cleanup may > be null (move assignment after the check) or not (remove the check) > > Could you fix that? Since the Brocade folks can't be bothered to fix this for more than a week I'll take care of this, thanks Jiri. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <AANLkTi=cZyLYJac8b8MsyAA4HitCvpD3NaH7nifzHDLw@mail.gmail.com>]
* Re: bna: potential null dereference [not found] ` <AANLkTi=cZyLYJac8b8MsyAA4HitCvpD3NaH7nifzHDLw@mail.gmail.com> @ 2010-09-12 22:38 ` David Miller 2010-09-12 22:41 ` Debashis Dutt 0 siblings, 1 reply; 4+ messages in thread From: David Miller @ 2010-09-12 22:38 UTC (permalink / raw) To: debdut; +Cc: jirislaby, ddutt, rmody, netdev, linux-kernel From: Debashis Dutt <debdut@gmail.com> Date: Sun, 12 Sep 2010 15:35:41 -0700 > A patch is on the way by tomorrow. BTW, this is just an unnecessary > check that should be removed and not a NULL de-reference. I've already made a fix in the net-next-2.6 tree. You should send me fixes like this when you have them and are reasonably confident of the change, which for something like this should have been a day or two at most, not a week later. ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: bna: potential null dereference 2010-09-12 22:38 ` David Miller @ 2010-09-12 22:41 ` Debashis Dutt 0 siblings, 0 replies; 4+ messages in thread From: Debashis Dutt @ 2010-09-12 22:41 UTC (permalink / raw) To: David Miller, debdut@gmail.com Cc: jirislaby@gmail.com, Rasesh Mody, netdev@vger.kernel.org, linux-kernel@vger.kernel.org -----Original Message----- From: David Miller [mailto:davem@davemloft.net] Sent: Sunday, September 12, 2010 3:38 PM To: debdut@gmail.com Cc: jirislaby@gmail.com; Debashis Dutt; Rasesh Mody; netdev@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: bna: potential null dereference From: Debashis Dutt <debdut@gmail.com> Date: Sun, 12 Sep 2010 15:35:41 -0700 > A patch is on the way by tomorrow. BTW, this is just an unnecessary > check that should be removed and not a NULL de-reference. I've already made a fix in the net-next-2.6 tree. You should send me fixes like this when you have them and are reasonably confident of the change, which for something like this should have been a day or two at most, not a week later. Sure David. Apologize for the delay again. Had too many things on my plate. Would be more prompt hence forth. Thanks --Debashis ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-12 22:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-04 12:59 bna: potential null dereference Jiri Slaby
2010-09-12 19:02 ` David Miller
[not found] ` <AANLkTi=cZyLYJac8b8MsyAA4HitCvpD3NaH7nifzHDLw@mail.gmail.com>
2010-09-12 22:38 ` David Miller
2010-09-12 22:41 ` Debashis Dutt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).