From: Peppe CAVALLARO <peppe.cavallaro@st.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
ML netdev <netdev@vger.kernel.org>
Subject: Re: STMMAC: sleep inside atomic
Date: Mon, 6 Sep 2010 11:47:20 +0200 [thread overview]
Message-ID: <4C84B8A8.5080503@st.com> (raw)
In-Reply-To: <4C8231E8.5090001@gmail.com>
Hi Jiri,
On 9/4/2010 1:47 PM, Jiri Slaby wrote:
>
> Hi,
>
> stanse found that the driver may sleep inside atomic:
> stmmac_resume
> -> spin_lock
> -> stmmac_open
> -> request_irq
> -> kzalloc(..., GFP_KERNEL);
> -> init_dma_desc_rings
> -> kmalloc(..., GFP_KERNEL);
> -> and many others...
> -> spin_unlock
>
> Could you fix that?
>
Yes I could ... kmalloc(...,GFP_KERNEL) can sleep!
I will fix the spinlock usage in the driver's resume function and send a
patch to the mailing list asap.
Many thanks to have found it.
Regards,
Peppe
>
>
> regards,
> --
> js
>
next prev parent reply other threads:[~2010-09-06 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 11:47 STMMAC: sleep inside atomic Jiri Slaby
2010-09-06 9:47 ` Peppe CAVALLARO [this message]
2010-09-06 19:25 ` Jiri Slaby
2010-09-06 20:08 ` David Miller
2010-09-06 20:55 ` Jiri Slaby
2010-09-07 0:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C84B8A8.5080503@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=jirislaby@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).