From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped Date: Wed, 08 Sep 2010 12:09:16 -0700 Message-ID: <4C87DF5C.70801@zytor.com> References: <20100901213318.19353.54619.stgit@localhost.localdomain> <41621.148.87.67.139.1283378664.squirrel@www.xenotime.net> <1283379098.28591.20.camel@pjaxe> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "rdunlap@xenotime.net" , "tglx@linutronix.de" , "mingo@redhat.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "andi@firstfloor.org" , "netdev@vger.kernel.org" To: Peter P Waskiewicz Jr Return-path: In-Reply-To: <1283379098.28591.20.camel@pjaxe> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/01/2010 03:11 PM, Peter P Waskiewicz Jr wrote: > On Wed, 2010-09-01 at 15:04 -0700, rdunlap@xenotime.net wrote: >> On Wed, September 1, 2010 2:33 pm, Peter P Waskiewicz Jr wrote: >>> Documentation/x86/x86_64/boot-options.txt | 4 ++++ >>> arch/x86/mm/srat_64.c | 20 +++++++++++++++++--- 2 >>> files changed, 21 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c index >>> f9897f7..8719472 100644 --- a/arch/x86/mm/srat_64.c >>> +++ b/arch/x86/mm/srat_64.c >>> @@ -351,6 +351,15 @@ int __init acpi_get_nodes(struct bootnode *physnodes) >>> return ret; } >>> >>> >>> +int srat_bypass_bios = 0; >> >> static int srat_bypass_bios; >> >> Don't need to init to 0. > > I'll fix and send a second version. Thanks Randy. > Should be static *bool* srat_bypass_bios; Please use bool for actual booleans; it prevents someone from being "smart" and using values like 2 or -1 for "special cases". -hpa