From: Michael Williamson <michael.williamson@criticallink.com>
To: cyril@ti.com
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
"tony@atomide.com" <tony@atomide.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v3 00/10] split out emac cpdma and mdio for reuse
Date: Thu, 09 Sep 2010 14:43:12 -0400 [thread overview]
Message-ID: <4C892AC0.80409@criticallink.com> (raw)
In-Reply-To: <4C882EAA.9030903@criticallink.com>
On 9/8/2010 8:47 PM, Michael Williamson wrote:
> Hi Cyril,
>
> On 09/08/2010 05:59 PM, Cyril Chemparathy wrote:
>> Hi Mike,
>>
>
> So I went in and set the debug_level to netif_msg_init() to -1 in the davinci_emac
> driver. The only thing I get during the boot process is:
>
> net eth0: DaVinci EMAC Probe found device (regs: 01e23000, irq: 33)
>
> which is good (I also added some debug to make sure probe actually completes), but
> I don't see *anything* else. I guess I would have expected to see something out of
> the emac_dev_open. So I added some more debug in there, it's hanging in the
> phy_connect() call. The phy_id it came up with was correct "0:03".
>
>
The hang is in wait_for_user_access() in the davinci_mdio_read() call. Looks like
the state machine got put back into IDLE somewhere between the MDIO probe and the
EMAC probe. Seems like there should be some sort of time-out and error message
in the wait_for_user_access() method.... (maybe even a check for IDLE??)
If I add a patch to check the state machine for IDLE and then re-enable it in the
davinci_mdio_read() call, it is able to press on and come up. I don't see any calls
to the davinci_mdio_suspend() call, so I am wondering if the EMAC probe routine,
particularly the application of the SOFTRESET, is causing the MDIO to drop back to
IDLE / disabled.
I can post the patch if you like, but it is a bit of a hack...
-Mike
next prev parent reply other threads:[~2010-09-09 18:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 20:25 [PATCH v3 00/10] split out emac cpdma and mdio for reuse Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 01/10] net: davinci_emac: separate out davinci mdio Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 02/10] davinci: add mdio platform devices Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 03/10] omap: " Cyril Chemparathy
2010-09-08 1:00 ` Tony Lindgren
2010-09-07 20:25 ` [PATCH v3 04/10] net: davinci_emac: switch to new mdio Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 05/10] davinci: cleanup unused davinci mdio arch code Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 06/10] omap: " Cyril Chemparathy
2010-09-08 1:00 ` Tony Lindgren
2010-09-07 20:25 ` [PATCH v3 07/10] net: davinci_emac: cleanup unused mdio emac code Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 08/10] net: davinci_emac: separate out cpdma code Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 09/10] net: davinci_emac: switch to new cpdma layer Cyril Chemparathy
2010-09-07 20:25 ` [PATCH v3 10/10] net: davinci_emac: cleanup unused cpdma code Cyril Chemparathy
2010-09-08 1:18 ` [PATCH v3 00/10] split out emac cpdma and mdio for reuse Kevin Hilman
2010-09-08 2:22 ` Michael Williamson
2010-09-08 21:59 ` Cyril Chemparathy
2010-09-09 0:47 ` Michael Williamson
2010-09-09 18:43 ` Michael Williamson [this message]
2010-09-09 19:51 ` Cyril Chemparathy
2010-09-09 21:24 ` Cyril Chemparathy
2010-09-09 21:45 ` Michael Williamson
2010-09-09 21:25 ` Michael Williamson
2010-09-10 15:23 ` Caglar Akyuz
2010-09-11 8:54 ` Caglar Akyuz
2010-09-13 14:09 ` Cyril Chemparathy
2010-09-13 15:46 ` Cyril Chemparathy
2010-09-13 17:51 ` Caglar Akyuz
2010-09-10 22:59 ` Cyril Chemparathy
2010-09-11 13:14 ` Michael Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C892AC0.80409@criticallink.com \
--to=michael.williamson@criticallink.com \
--cc=cyril@ti.com \
--cc=davem@davemloft.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).