From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Hellstrom Subject: Re: SPARC32 SMP 2.6.36-rc3 build error Date: Wed, 15 Sep 2010 09:20:00 +0200 Message-ID: <4C9073A0.5090409@gaisler.com> References: <4C8F78F3.7020408@gaisler.com> <20100914.214235.183040334.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: sparclinux@vger.kernel.org, netdev@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20100914.214235.183040334.davem@davemloft.net> Sender: sparclinux-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Miller wrote: >From: Daniel Hellstrom >Date: Tue, 14 Sep 2010 15:30:27 +0200 > > > >>I have problems linking Linux SPARC32 when SMP is enabled: >> >> LD vmlinux >> SYSMAP System.map >> SYSMAP .tmp_System.map >> BTFIX arch/sparc/boot/btfix.S >> AS arch/sparc/boot/btfix.o >> LD arch/sparc/boot/image >>net/built-in.o: In function `net_rps_action_and_irq_enable': >>/home/daniel/linux/linux/linux-2.6/net/core/dev.c:3337: undefined >>reference to `__smp_call_function_single' >>make[1]: *** [arch/sparc/boot/image] Error 1 >>make: *** [zImage] Error 2 >> >> > >It's a missing dependency in the networking code, I'll fix this >in the net-2.6 tree as follows: > >-------------------- >net: RPS needs to depend upon USE_GENERIC_SMP_HELPERS > >You cannot invoke __smp_call_function_single() unless the >architecture sets this symbol. > >Reported-by: Daniel Hellstrom >Signed-off-by: David S. Miller >--- > net/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/net/Kconfig b/net/Kconfig >index e330594..e926884 100644 >--- a/net/Kconfig >+++ b/net/Kconfig >@@ -217,7 +217,7 @@ source "net/dns_resolver/Kconfig" > > config RPS > boolean >- depends on SMP && SYSFS >+ depends on SMP && SYSFS && USE_GENERIC_SMP_HELPERS > default y > > menu "Network testing" > > That resolved the problem nicely. Thank you very much, Daniel