From: Patrick McHardy <kaber@trash.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Daniel Lezcano <daniel.lezcano@free.fr>,
David Lamparter <equinox@diac24.net>
Subject: Re: [PATCH RFC] netns: keep vlan slaves on master netns move
Date: Fri, 17 Sep 2010 14:49:15 +0200 [thread overview]
Message-ID: <4C9363CB.7050302@trash.net> (raw)
In-Reply-To: <m1bp7z4v0m.fsf@fess.ebiederm.org>
Am 15.09.2010 04:10, schrieb Eric W. Biederman:
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> My inclination is that the best way to handle this is to would be to
> push the device deletion for vlan and macvlan devices into the device
> core, where we could get the advantage of batched deletions.
We've added batched deletion to both about a year ago, what exactly
is the problem?
> Right
> now vlan and macvlan devices are the only devices I know of that cause
> other devices to be removed during unregister, so removing that
> specialness seems reasonable.
Actually all devices can cause this when used as a lower device by
vlan or macvlan. Both vlan and macvlan are useless without a lower
device, so I don't see why we shouldn't remove them when the lower
device is unregistered.
> However not being able to move the primary vlan to a different network
> namespace is usability bug with no real alternatives. There are
> not any other patches on the table right now, and your patch below
> seems obviously correct. Let's get this merged before we forget about
> this, bug fix.
Looks reasonable to me.
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2010-09-17 12:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 11:50 [PATCH RFC] netns: keep vlan slaves on master netns move David Lamparter
2010-08-24 17:00 ` Daniel Lezcano
2010-08-24 19:14 ` Eric W. Biederman
2010-08-25 11:52 ` [PATCH RFC] netns: introduce NETREG_NETNS_MOVING reg_state David Lamparter
2010-08-25 13:03 ` Daniel Lezcano
2010-08-25 13:52 ` David Lamparter
2010-08-25 17:39 ` Eric W. Biederman
2010-08-26 8:21 ` David Lamparter
2010-09-13 11:43 ` [PATCH RFC] netns: keep vlan slaves on master netns move David Lamparter
2010-09-15 2:10 ` Eric W. Biederman
2010-09-17 12:49 ` Patrick McHardy [this message]
2010-09-27 16:23 ` Eric W. Biederman
2010-09-17 13:22 ` [PATCH] " David Lamparter
2010-09-17 17:56 ` David Miller
2010-09-15 6:47 ` [PATCH RFC] " Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9363CB.7050302@trash.net \
--to=kaber@trash.net \
--cc=daniel.lezcano@free.fr \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=equinox@diac24.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).